We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reselect: v4.0.0
It looks like when using the props argument in selectors, there is a typing issue when the props of 2 selectors have overlapping keys.
Consider following code
const fooPropSelector = (_: {}, ownProps: { foo: string }) => ownProps.foo; const fooBarPropsSelector = (_: {}, ownProps: { foo: string; bar: string; }) => [ownProps.foo, ownProps.bar]; const combinedSelector = createSelector( fooPropSelector, fooBarPropsSelector, (foo, fooBar) => fooBar );
In this example the type of the combinedSelector results in:
OutputParametricSelector<{}, { foo: string; }, string[], (res1: string, res2: string[]) => string[]>
Whereas it should be
OutputParametricSelector<{}, { foo: string; bar: string; }, string[], (res1: string, res2: string[]) => string[]>
The text was updated successfully, but these errors were encountered:
I just published https://github.com/reduxjs/reselect/releases/tag/v4.1.0-alpha.0 , which rewrites the TS types. Can you see if that works better for you?
Sorry, something went wrong.
Should be fixed by #486 .
No branches or pull requests
Reselect: v4.0.0
It looks like when using the props argument in selectors, there is a typing issue when the props of 2 selectors have overlapping keys.
Consider following code
In this example the type of the combinedSelector results in:
Whereas it should be
The text was updated successfully, but these errors were encountered: