Javascript Best practices : DRY and YAGNI

[redwing555]

Give this function the taskArr as a variable so It can be used whenever I need to update the localStorage provided the right array :

todo-list/src/crud.js

Lines 3 to 6 in ab9ced7

	function addTaskToStorage() {
	const tasksInfo = JSON.stringify(tasks);
	localStorage.setItem('tasksList', tasksInfo);
	}

call addTaskToStorage(taskArr) instead of localStorage.setItem('tasksList', JSON.stringify(taskArr)); in the following lines of code :

todo-list/src/crud.js

Lines 19 to 31 in ab9ced7

	export function deleteCompletedTask(taskArr) {
	const storeLength = JSON.parse(localStorage.getItem('tasksList')).length;
	taskArr = taskArr.filter((task) => task.completed === false);
	localStorage.setItem('tasksList', JSON.stringify(taskArr));
	window.location.reload();
	/* eslint-disable */
	taskArr.forEach((task, i) => task.index = Array.from(Array(storeLength).keys())[i]);
	/* eslint-enable */
	localStorage.setItem('tasksList', JSON.stringify(taskArr));
	}

todo-list/src/crud.js

Lines 33 to 46 in ab9ced7

	function moveToTrash(taskArr) {
	const trashCan = [...document.querySelectorAll('.trash')];
	const storeLength = JSON.parse(localStorage.getItem('tasksList')).length;
	trashCan.forEach((can) => can.addEventListener('click', () => {
	taskArr = taskArr.filter((task) => task.index !== parseInt(can.id[6], 10));
	localStorage.setItem('tasksList', JSON.stringify(taskArr));
	window.location.reload();
	/* eslint-disable */
	taskArr.forEach((task, i) => task.index = Array.from(Array(storeLength).keys())[i]);
	/* eslint-enable */
	localStorage.setItem('tasksList', JSON.stringify(taskArr));
	}));
	}

todo-list/src/index.js

Lines 74 to 77 in ab9ced7

	refresh.addEventListener('click', () => {
	localStorage.setItem('tasksList', JSON.stringify([]));
	window.location.reload();
	});

todo-list/src/methods.js

Lines 13 to 15 in ab9ced7

	JSON.parse(localStorage.getItem('tasksList'));
	localStorage.setItem('tasksList', JSON.stringify(tasksArr));
	}));

Also export the addTaskToStorage function and import it in both methods.js and index.js

[redwing555]

use spread operator [...Array(storeLength).keys()] to generate a JavaScript array containing 1 through to storeLength :

todo-list/src/crud.js

Line 28 in ab9ced7

taskArr.forEach((task, i) => task.index = Array.from(Array(storeLength).keys())[i]);