Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade from 0.35.2 to 0.36.2 GraqhQL comment does not work #3313

Closed
wongyouth opened this issue Sep 1, 2021 · 4 comments · Fixed by #3371
Closed

After upgrade from 0.35.2 to 0.36.2 GraqhQL comment does not work #3313

wongyouth opened this issue Sep 1, 2021 · 4 comments · Fixed by #3371

Comments

@wongyouth
Copy link

wongyouth commented Sep 1, 2021

Add a comment line for field in file api/src/graphql/userExamples.sdl.js

  input UpdateUserExampleInput {
    email: String
    """
    Name is a nickname
    """
    name: String
  }

will raise error

api | (node:1723) UnhandledPromiseRejectionWarning: GraphQLError: Syntax Error: Expected Name, found BlockString "Name is a nickname".
api |     at syntaxError (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/error/syntaxError.js:15:10)
api |     at Parser.expectToken (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:1413:40)
api |     at Parser.parseName (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:98:22)
api |     at Parser.parseInputValueDef (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:911:21)
api |     at Parser.optionalMany (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:1503:28)
api |     at Parser.parseInputFieldsDefinition (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:1065:17)
api |     at Parser.parseInputObjectTypeDefinition (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:1049:23)
api |     at Parser.parseTypeSystemDefinition (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:720:23)
api |     at Parser.parseDefinition (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:150:23)
api |     at Parser.many (/Users/ryan/code/demos/redwood-v0.36.2/node_modules/graphql/language/parser.js:1523:26)
@redwoodjs-bot redwoodjs-bot bot added this to New issues in Current-Release-Sprint Sep 1, 2021
@dac09
Copy link
Collaborator

dac09 commented Sep 1, 2021

Thanks for reporting this @wongyouth and a great specific bug report - we've seen this happening due to the latest version of graphql-tools. We will issue a patch as soon as its fixed on their side!

@Tobbe
Copy link
Member

Tobbe commented Sep 8, 2021

@dac09 Are the graphql-tools guys aware of the issue? I took a quick look through their issues, but didn't spot anything. https://github.com/ardatan/graphql-tools/issues

@Tobbe
Copy link
Member

Tobbe commented Sep 8, 2021

Found it :) ardatan/graphql-tools#3244
And it's fixed! Even better :)

@thedavidprice
Copy link
Contributor

Hi all, this will be resolved via #3371, which is targeted for v0.37 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants