Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Can't customize Storybook! #6854

Open
1 task
theoradicella opened this issue Nov 10, 2022 · 3 comments
Open
1 task

[Bug?]: Can't customize Storybook! #6854

theoradicella opened this issue Nov 10, 2022 · 3 comments

Comments

@theoradicella
Copy link

theoradicella commented Nov 10, 2022

What's not working?

I wan't to disable essential addons from storybook but since Redwood merges it's own config, (which includes essential addons) I'm not able to do it.

Here I have opened the issue in the community: https://community.redwoodjs.com/t/build-error-when-configuring-storybook/4274/2

How do we reproduce the bug?

No response

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@theoradicella theoradicella added the bug/needs-info More information is needed for reproduction label Nov 10, 2022
@simoncrypta
Copy link
Collaborator

@theoradicella That's true that Redwood have an opinionated base Storybook config, maybe we should have a way to overwrite the config. What do you think @virtuoushub ?

@simoncrypta simoncrypta self-assigned this Nov 11, 2022
@theoradicella
Copy link
Author

That would be really useful. We are not using essential addons and we would really like to have our storybook clean. I'll be waiting for this. Thanks!

@virtuoushub
Copy link
Collaborator

@theoradicella That's true that Redwood have an opinionated base Storybook config, maybe we should have a way to overwrite the config. What do you think @virtuoushub ?

I agree.

In the short term to solve this particular use case, a config option can be added to this line https://github.com/redwoodjs/redwood/blob/main/packages/testing/config/storybook/main.js#L29 similarly to how we are doing a11y the line below so that adding '@storybook/addon-essentials' is conditional based on the framework user's need.

@simoncrypta simoncrypta removed the bug/needs-info More information is needed for reproduction label Dec 9, 2022
@simoncrypta simoncrypta removed their assignment Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants