-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC]: setup commands for Material UI #9141
Comments
👋 Hey @oliviertassinari - it has been a while since I used MUI - what would be the requirements for setup with RW? From their install page, it seems fairly straightforward. I was going through the rw mantine/chakra/tailwind setup commands and they configure storybook at a certain step. I see this recipe from storybook on integrating MUI, with a codemod. Not sure if that would be needed. If it is as straightforward as the mantine install page makes it look, would you (or anyone reading this) be up for submitting a PR for it? |
Hey @oliviertassinari, I brought this RFC up to the team today. We don't think we'd add something like this to core at the moment. We have a suite of features we're focused on (see the roadmap: https://redwoodjs.com/roadmap) and we're trying to stay dialed in. Once #8920 is merged, there'd be a first-class way of integrating with the Redwood CLI without adding code to core. But even without #8920, you could use this thread as an example of building on Redwood: https://community.redwoodjs.com/t/announcing-dbauth-oauth-plugin-v1-0-0-easily-enable-sign-in-with-apple-github-google-and-more/5118. (But I understand that half the value proposition of adding it to core is so that it's official and maintained. So no pressure to run with any of these suggestions, just wanted to empower you!) |
Thanks for the update. My goal was to have a placeholder where the community can shine in to collaborate, to make the integration with Material UI happen. I think this simply creating this GitHub issue was enough to serve this purpose. It looks like there is also Discourse, I missed it https://community.redwoodjs.com/search?q=Material%20UI |
@oliviertassinari happy to leave it open for that reason |
Is a PR for this worthwhile or just discussion? I got most of it working yesterday but stopped short of figuring out Storybook (before I deleted everything when the issue was closed). I'm currently using MUI and Redwood and would love to work on this if it would be useful. |
@jlthompso thank you! There are two aspects you should be aware of:
You'd be welcome to open a PR here as long as you understand that it won't be merged and we might not be able to give a prompt review. The advantage would be:
An option here could be to host the setup package in the RedwoodJS GitHub org. We could add you as an admin for the Repo. Again, we don't want to "own" this project. But we'd be very excited to find ways to support you and efforts like this in a sustainable way for everyone involved. |
Summary
Similar to the other UI libraries, https://redwoodjs.com/docs/cli-commands#setup-ui.
Motivation
Material UI is the most downloaded UI library in the React ecosystem as of today, about 25% of the downloads. I'm creating this issue so the community has a place to express their interest by upvoting it, and maybe contribute if there is enough traction.
Detailed proposal
See above
Are you interested in working on this?
The text was updated successfully, but these errors were encountered: