Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Routes should use encodeURIComponent when appending unnamed params #9839

Closed
1 task
sean-ac opened this issue Jan 16, 2024 · 1 comment · Fixed by #9844
Closed
1 task

[Bug?]: Routes should use encodeURIComponent when appending unnamed params #9839

sean-ac opened this issue Jan 16, 2024 · 1 comment · Fixed by #9844

Comments

@sean-ac
Copy link

sean-ac commented Jan 16, 2024

What's not working?

Doing something like:

routes.homePage({ search: 'home & garden' });

Produces a route:

/home?search=home%20&%20garden

Which is malformed due to missing encodeURIComponent.

I believe the bug is on this line:

https://github.com/redwoodjs/redwood/blob/v6.6.2/packages/router/src/util.ts#L340

How do we reproduce the bug?

No response

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@sean-ac sean-ac added the bug/needs-info More information is needed for reproduction label Jan 16, 2024
@Tobbe
Copy link
Member

Tobbe commented Jan 17, 2024

Thanks for your issue report. And even linking to the code needed to change is awesome 🙏

I'll try to take a look sometime this week

@Tobbe Tobbe self-assigned this Jan 17, 2024
@Tobbe Tobbe added topic/router-&-navigation and removed bug/needs-info More information is needed for reproduction labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants