Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize.css -> modern-normalize #48

Closed
pavelloz opened this issue Apr 14, 2022 · 5 comments
Closed

normalize.css -> modern-normalize #48

pavelloz opened this issue Apr 14, 2022 · 5 comments

Comments

@pavelloz
Copy link
Contributor

Hello,

Have you thought about switching normalize.css to modern normalize?
Ive seen many modern projects switching, and it seems like the approach is pretty in line with your target group (devs usually dont use ie 11 nowadays :) )

Repo: https://github.com/sindresorhus/modern-normalize

@cannikin
Copy link
Member

Do we have an explicit include of normalize? I thought that was included by Tailwind itself? Is it possible to override with something else?

@pavelloz
Copy link
Contributor Author

Ouh, i think i made a mistake. There is a file that contains normalize.css comment, but everything below is not normalize at all - i got fooled :)

I think you are right about Tailwind - it has normalize, and to be precise, modern-normalize that i proposed, so all good.
https://tailwindcss.com/docs/preflight#overview

Sorry for confusion.

@cannikin
Copy link
Member

I think it may have started as normalize but then we customized it a bit (prefixed with .rw-scaffold). If you have any improvements feel free to PR!

@pavelloz
Copy link
Contributor Author

pavelloz commented Apr 19, 2022

@cannikin
Im far too fresh in the codebase yet to suggest something, need a little bit more time.
Until then I will contribute on the subject that im very confident in: performance :)

Organizational question:
Should I create PRs if previous ones are not merged? I dont want to:

  1. swamp anyone
  2. create potential conflicts with any other plans
  3. create PRs that will be open for long time

@jtoar
Copy link
Contributor

jtoar commented Apr 19, 2022

Should I create PRs if previous ones are not merged?

TL;DR yes, but you're right in that we need to get better at moving the PRs we have forward. But still, if you want to improve something, by all means, please make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants