Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Possible solution to issue #10 #11

Merged
merged 6 commits into from Sep 14, 2018
Merged

Conversation

MachineMitch21
Copy link
Contributor

Here is a possible way to do enabling and disabling of systems prompted by fabslabs request. This way would seperate the disabled systems into their own std::vector. That way the World wouldn't have to check each system for any kind of disabled flag. Systems would just be removed from the main systems vector and moved into a disabledSystems vector. Then they would be removed from disabledSystems and back into the main systems vector upon being enabled again. Also, not sure about how you'd feel about having registerSystem return the EntitySystem*. Maybe there's a better way to handle that.

@redxdev
Copy link
Owner

redxdev commented Sep 14, 2018

Looks good to me, but you need to fix indentation to match up with the rest of the project.

@MachineMitch21
Copy link
Contributor Author

This is very strange. The indentation is fine in all the editors I open up. It appears to be changing when I push it, though, for some reason.

@MachineMitch21
Copy link
Contributor Author

screenshot 11

@redxdev
Copy link
Owner

redxdev commented Sep 14, 2018

Check if you're using tabs while the rest of the project is using spaces (or vice versa, I don't remember off the top of my head what was used). I'd check myself but I won't be able to for a few hours at least.

@MachineMitch21
Copy link
Contributor Author

The problem was that my editor was set for 4 space tabs and you have 8 space tabs. So it truncated the files down to be 4 space tabs all around. Everything should be conformant to your indentation now.

@redxdev redxdev merged commit 6adcbb1 into redxdev:master Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants