Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer Sass file over CSS #2

Closed
rebz opened this issue Feb 5, 2018 · 4 comments
Closed

Offer Sass file over CSS #2

rebz opened this issue Feb 5, 2018 · 4 comments

Comments

@rebz
Copy link

rebz commented Feb 5, 2018

Would be great if the Sass file was included as an option.

@redxtech
Copy link
Owner

redxtech commented Feb 5, 2018

I don't use a sass file here. I just import the dist/plyr.css from plyr. You can get the same file from putting the following code in your sass file after npm install plyr or yarn add plyr.

@import '~plyr/src/scss/plyr

@rebz
Copy link
Author

rebz commented Feb 6, 2018

That actually makes more sense. Thank you.

@rebz rebz closed this as completed Feb 6, 2018
@mortensassi
Copy link

Like other Plugin Devs it would be preferable to just let the user import the sass in order to modify the appearance. now if you additionally import the scss file you get twice the css in your app and the overrides won't even work since they get overridden by your imported css file

@maximelebreton
Copy link

Hello.
Please Repoen this issue, and add the ability to disable css style import, or like @mortensassi said, let the dev import the css.
Currently we have no way import our own Sass style, because the default style overrides our custom Sass stylesheet.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants