Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): allow mouse event for react-dnd #638

Merged
merged 2 commits into from Aug 28, 2023

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Aug 24, 2023

Overview

In PlateauView3.0, we need to use the mouse event for document to manage the state of popup. However WAS stops the propagation of the events. So I fixed to allow the propagation of the mouse events in react-dnd.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@keiya01 keiya01 requested a review from KaWaite as a code owner August 24, 2023 01:02
@keiya01 keiya01 self-assigned this Aug 24, 2023
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 393a1c7
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64e6f0d303d8150008713fe0
😎 Deploy Preview https://deploy-preview-638--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 24, 2023
@github-actions github-actions bot requested a review from pyshx August 24, 2023 01:03
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #638 (393a1c7) into main (0ef6a88) will increase coverage by 0.17%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
+ Coverage   27.91%   28.09%   +0.17%     
==========================================
  Files        1459     1483      +24     
  Lines      158959   160740    +1781     
  Branches     3737     3737              
==========================================
+ Hits        44378    45161     +783     
- Misses     113491   114423     +932     
- Partials     1090     1156      +66     
Flag Coverage Δ
web 26.07% <ø> (ø)
web-beta 26.07% <ø> (ø)
web-classic 26.07% <ø> (ø)
web-utils 26.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
server/e2e/common.go 65.38% <ø> (+0.16%) ⬆️
server/internal/app/config/config.go 43.85% <ø> (ø)
server/internal/app/repo.go 0.00% <ø> (ø)
server/internal/infrastructure/mongo/container.go 0.00% <ø> (ø)
server/internal/usecase/interactor/dataset.go 0.00% <ø> (ø)
server/internal/usecase/interactor/layer.go 3.51% <ø> (ø)
server/internal/usecase/repo/container.go 40.90% <ø> (+0.24%) ⬆️

... and 57 files with indirect coverage changes

@keiya01 keiya01 changed the title fix(web): allow mouse event on WAS fix(web): allow mouse event on react-dnd Aug 24, 2023
@keiya01 keiya01 changed the title fix(web): allow mouse event on react-dnd fix(web): allow mouse event for react-dnd Aug 24, 2023
@keiya01 keiya01 enabled auto-merge (squash) August 24, 2023 05:55
@keiya01 keiya01 disabled auto-merge August 24, 2023 05:55
@keiya01 keiya01 merged commit 2ed816b into main Aug 28, 2023
17 checks passed
@keiya01 keiya01 deleted the fix/allow-mouse-event-on-widget-editor branch August 28, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant