Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): story page update #714

Merged
merged 44 commits into from
Oct 16, 2023
Merged

chore(web): story page update #714

merged 44 commits into from
Oct 16, 2023

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Sep 28, 2023

Overview

What I've done

  • hide/show state shown in check-boxes
  • on checkbox click update page with/without layerId
  • update visualizer to show only certain layers depending on page selected

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ee83da5
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/652a5987f7f53d00095f2584
😎 Deploy Preview https://deploy-preview-714--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #714 (ee83da5) into main (ead2f52) will decrease coverage by 0.03%.
The diff coverage is 2.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   26.74%   26.71%   -0.03%     
==========================================
  Files        1583     1584       +1     
  Lines      172760   172931     +171     
  Branches     3913     3914       +1     
==========================================
+ Hits        46199    46204       +5     
- Misses     125472   125638     +166     
  Partials     1089     1089              
Flag Coverage Δ
web 25.06% <2.60%> (-0.03%) ⬇️
web-beta 25.06% <2.60%> (-0.03%) ⬇️
web-classic 25.06% <2.60%> (-0.03%) ⬇️
web-utils 25.06% <2.60%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/services/api/storytellingApi/utils.ts 60.29% <100.00%> (+0.59%) ⬆️
web/src/beta/features/Editor/index.tsx 0.00% <0.00%> (ø)
...src/beta/lib/core/engines/Cesium/Feature/index.tsx 32.56% <0.00%> (ø)
web/src/services/api/storytellingApi/index.ts 21.73% <0.00%> (-0.32%) ⬇️
...ta/features/Editor/tabs/story/RightPanel/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/index.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/Visualizer/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useRightPanel.tsx 0.00% <0.00%> (ø)
web/src/beta/features/Editor/useStorytelling.ts 0.00% <0.00%> (ø)
web/src/services/api/storytellingApi/pages.ts 23.35% <13.79%> (-2.57%) ⬇️
... and 2 more

@mkumbobeaty mkumbobeaty marked this pull request as ready for review October 3, 2023 05:35
@mkumbobeaty mkumbobeaty requested a review from pyshx October 3, 2023 05:35
web/src/beta/lib/core/Map/ClusteredLayers/index.tsx Outdated Show resolved Hide resolved
web/src/beta/lib/core/Map/Layers/index.tsx Outdated Show resolved Hide resolved
web/src/beta/lib/core/Map/index.tsx Outdated Show resolved Hide resolved
web/src/beta/lib/core/Visualizer/index.tsx Outdated Show resolved Hide resolved
@KaWaite KaWaite self-requested a review October 13, 2023 07:33
@mkumbobeaty mkumbobeaty merged commit 86d4b9c into main Oct 16, 2023
16 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/storyPage-update branch October 16, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants