Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Updated fields in Settings #741

Merged
merged 17 commits into from Oct 25, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Oct 17, 2023

Overview

  • Property Fields in settings Page

What I've done

  • Added textaread field
  • textinput now supports disabled flag
  • Updated fields in settings page

What I haven't done

  • NA

How I tested

  • UI

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 26353ed
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65389b7b04fc8d0008b6bc87
😎 Deploy Preview https://deploy-preview-741--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 17, 2023
@github-actions github-actions bot requested a review from nina992 October 17, 2023 19:10
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #741 (3570497) into main (a8fb535) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 3570497 differs from pull request most recent head 26353ed. Consider uploading reports for the commit 26353ed to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   26.42%   26.39%   -0.03%     
==========================================
  Files        1602     1603       +1     
  Lines      175365   175556     +191     
  Branches     3929     3930       +1     
==========================================
  Hits        46337    46337              
- Misses     127939   128130     +191     
  Partials     1089     1089              
Flag Coverage Δ
web 24.69% <0.00%> (-0.04%) ⬇️
web-beta 24.69% <0.00%> (-0.04%) ⬇️
web-classic 24.69% <0.00%> (-0.04%) ⬇️
web-utils 24.69% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../beta/components/fields/common/TextInput/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/fields/TextField/index.tsx 0.00% <0.00%> (ø)
...s/innerPages/StorySettings/StorySettingsDetail.tsx 0.00% <0.00%> (ø)
...ojectSettings/innerPages/GeneralSettings/index.tsx 0.00% <0.00%> (ø)
...innerPages/PublicSettings/PublicSettingsDetail.tsx 0.00% <0.00%> (ø)
...src/beta/components/fields/TextAreaField/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@KaWaite KaWaite changed the title chore(web): Updated fiels in Settings chore(web): Updated fields in Settings Oct 18, 2023
@jashanbhullar jashanbhullar merged commit 7fa4d50 into main Oct 25, 2023
12 checks passed
@jashanbhullar jashanbhullar deleted the chore(web)/settings-page-fields branch October 25, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants