Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): update switch layer block functionality #833

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Nov 23, 2023

Overview

  • some JP internationalization snuck in too...sorry!

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 8402f75
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65657d4520bc1f0008c4d933
😎 Deploy Preview https://deploy-preview-833--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #833 (8402f75) into main (d6bf3ef) will decrease coverage by 0.02%.
The diff coverage is 0.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   25.68%   25.67%   -0.02%     
==========================================
  Files        1637     1638       +1     
  Lines      180197   180326     +129     
  Branches     3912     3913       +1     
==========================================
+ Hits        46283    46291       +8     
- Misses     132825   132946     +121     
  Partials     1089     1089              
Flag Coverage Δ
server 33.35% <ø> (ø)
web 23.89% <0.77%> (-0.02%) ⬇️
web-beta 23.89% <0.77%> (-0.02%) ⬇️
web-classic 23.89% <0.77%> (-0.02%) ⬇️
web-utils 23.89% <0.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/components/Button/index.tsx 0.00% <ø> (ø)
web/src/services/api/sceneApi.ts 61.72% <100.00%> (+0.96%) ⬆️
.../lib/core/StoryPanel/Block/builtin/common/hooks.ts 0.00% <0.00%> (ø)
...c/beta/features/Editor/DataSourceManager/utils.tsx 0.00% <0.00%> (ø)
...itor/tabs/story/LeftPanel/ContentPage/PageItem.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
...eatures/Editor/tabs/map/BottomPanel/LayerStyle.tsx 0.00% <0.00%> (ø)
...res/Editor/DataSourceManager/ThreeDTiles/index.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/map/LeftPanel/Layers/LayerItem.tsx 0.00% <0.00%> (ø)
...c/beta/features/Editor/DataSourceManager/index.tsx 0.00% <0.00%> (ø)
... and 10 more

... and 3 files with indirect coverage changes

@KaWaite KaWaite marked this pull request as ready for review November 28, 2023 02:28
@KaWaite KaWaite requested a review from pyshx as a code owner November 28, 2023 02:28
@KaWaite KaWaite self-assigned this Nov 28, 2023
@KaWaite KaWaite merged commit ed2931e into main Nov 28, 2023
17 checks passed
@KaWaite KaWaite deleted the switch-layer-block-step-2 branch November 28, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant