-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): support built-in widget visible on WAS #839
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
=======================================
Coverage 25.63% 25.63%
=======================================
Files 1641 1643 +2
Lines 180588 180560 -28
Branches 3917 3917
=======================================
- Hits 46291 46287 -4
+ Misses 133208 133184 -24
Partials 1089 1089
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Overview
Visible
field has been added to built-in widgets since this PR.But only NLS WAS supports that feature. We need to support the same thing without NLS since the widget manifest is shared and from user view this is a bug that not working.
What I've done
invisibleWidgetIDs
in higher level. Layout (isMobile) / alignSystem / Builtin widget visible property change will trigger re-calculate.What I haven't done
How I tested
Which point I want you to review particularly
Memo