Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): support built-in widget visible on WAS #839

Merged
merged 18 commits into from Nov 30, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Nov 28, 2023

Overview

Visible field has been added to built-in widgets since this PR.
But only NLS WAS supports that feature. We need to support the same thing without NLS since the widget manifest is shared and from user view this is a bug that not working.

What I've done

  • Update classic classic WAS to support visible feature for built-in widgets.
  • Refactor some on visible implement on classic / classic NLS / beta.
    • Calculate invisibleWidgetIDs in higher level. Layout (isMobile) / alignSystem / Builtin widget visible property change will trigger re-calculate.
    • Move invisible check to higher level (in Areas). There will be empty container (will effect gap) if check in widget component level.

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 574bb47
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65670b931334d90007a20691
😎 Deploy Preview https://deploy-preview-839--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #839 (a2dd321) into main (42d9ed0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a2dd321 differs from pull request most recent head 574bb47. Consider uploading reports for the commit 574bb47 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #839   +/-   ##
=======================================
  Coverage   25.63%   25.63%           
=======================================
  Files        1641     1643    +2     
  Lines      180588   180560   -28     
  Branches     3917     3917           
=======================================
- Hits        46291    46287    -4     
+ Misses     133208   133184   -24     
  Partials     1089     1089           
Flag Coverage Δ
web 23.85% <0.00%> (+<0.01%) ⬆️
web-beta 23.85% <0.00%> (+<0.01%) ⬆️
web-classic 23.85% <0.00%> (+<0.01%) ⬆️
web-utils 23.85% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...re/Crust/Widgets/Widget/builtin/Navigator/hooks.ts 0.00% <ø> (ø)
...ore/Crust/Widgets/Widget/builtin/Timeline/hooks.ts 0.00% <ø> (ø)
...b/src/beta/lib/core/Crust/Widgets/Widget/index.tsx 0.00% <ø> (ø)
...molecules/Visualizer/Widget/SplashScreen/index.tsx 44.44% <ø> (+0.34%) ⬆️
...assic/core/Crust/Widgets/Widget/Navigator/hooks.ts 0.00% <ø> (ø)
...lassic/core/Crust/Widgets/Widget/Timeline/hooks.ts 0.00% <ø> (ø)
...eb/src/classic/core/Crust/Widgets/Widget/index.tsx 0.00% <ø> (ø)
...Crust/Widgets/Widget/builtin/Button/MenuButton.tsx 0.00% <0.00%> (ø)
...ic/core/Crust/Widgets/Widget/Button/MenuButton.tsx 0.00% <0.00%> (ø)
...c/core/Crust/Widgets/Widget/Storytelling/index.tsx 0.00% <0.00%> (ø)
... and 32 more

... and 3 files with indirect coverage changes

@airslice airslice self-assigned this Nov 28, 2023
@airslice airslice marked this pull request as ready for review November 29, 2023 02:25
@airslice airslice merged commit 227ae77 into main Nov 30, 2023
12 checks passed
@airslice airslice deleted the fix/built-in-widgets-visible branch November 30, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants