-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typings #22
Comments
I've had a very quick look at this, but getting the TypeScript definitions to play nicely with Webpack appears to be non-trivial. I've tried the following with no success:
I think this isn't working because we use I probably don't have a lot of time to look into this, as it's a nice-to-have. Please feel free to raise a PR if you think you can crack it, though. |
A trivial but ugly solution (until it is possible to move away from default exports) would be making a definition file by hand. As there are not that many methods this should be very easy and quick. Thoughts on that? |
Making one by hand is a bit icky in my opinion. I think I'd rather remove our |
Yeap. If it can be breaking better to bump, IMO. |
Should now hopefully be fixed by #54 Release coming soon. |
@alecgibson, can't wait for release! |
It would be great if the types were also generated upon build and added to the dist so that when using the plugin with TS people can make use of the typings
The text was updated successfully, but these errors were encountered: