Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare place in template for frontend development #34

Open
Valian opened this issue Dec 8, 2020 · 2 comments
Open

Prepare place in template for frontend development #34

Valian opened this issue Dec 8, 2020 · 2 comments

Comments

@Valian
Copy link

Valian commented Dec 8, 2020

Based on how it's done in reef.pl website project, it looks like whole frontend setup is inside app/src/frontend, where apps/src is also a backend root. It makes it harder to dockerize project properly - backend docker image also have whole frontend code inside and requires to manually build and check into source code bundle.js - minified JS file with whole compiled project.

Suggestion of a solution: prepare a separate directory for frontend that doesn't overlap with backend. Dockerize it, so building docker image also creates a minified bundle. During deploy copy that file into nginx staticfiles volume.

@mlech-reef
Copy link
Contributor

Actually, in reefpl it's done in a wrong way :D

Usually, it's exactly how you wrote, but the frontend part is not part of the template as it's not needed in most of the cases (other than django templates).

@ppolewicz
Copy link
Contributor

We think the amount of changes done to the frontend in reef.pl will be so low that it's not worth to automate it (we'll probably rewrite the thing before we achieve the return from investment)

Generally our template is not optimized for frontend at all. We do sometimes need to customize something for a client, at least a few times we've crafted something that works with their current frontend solution to make it work with our backend template - but those were so far apart from each other that extracting a common thing from them was not been practical so far. Maybe one day when we have more frontend work this will reoccur, but for now, I think we are conciously not automating it.... but.

If something has changed since it was last discussed (for example @Valian has recently implemented almost the exact same thing and could do it here very quickly, while other team members agree it would be useful), then go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants