Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-master base branch does not work for the deliver command #192

Closed
quanghiem opened this issue Jul 8, 2016 · 1 comment
Closed

non-master base branch does not work for the deliver command #192

quanghiem opened this issue Jul 8, 2016 · 1 comment
Milestone

Comments

@quanghiem
Copy link

I am using git reflow for our puppet codebase and we use the production branch as our base branch. Specifying the production base branch for the commands start, review, and status works, but is broken for deliver.

$  git reflow start fix_me --base production
git checkout production
Already on 'production'

git pull origin production
From git.xxx.org:ops/puppet
 * branch            production -> FETCH_HEAD
Current branch production is up to date.
git push origin production:refs/heads/fix_me
Total 0 (delta 0), reused 0 (delta 0)
To git@git.xxx.org:ops/puppet.git
 * [new branch]      production -> fix_me

git checkout --track -b fix_me origin/fix_me
Switched to a new branch 'fix_me'
Branch fix_me set up to track remote branch fix_me from origin by rebasing.
$  echo >> README.md
$  git add README.md
$  git commit -m "test commit"
[fix_me 3ee0b45] test commit
 1 file changed, 1 insertion(+)
$  git reflow review production
git fetch origin production
From git.xxx.org:ops/puppet
 * branch            production -> FETCH_HEAD

git push origin fix_me
Counting objects: 5, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 286 bytes | 0 bytes/s, done.
Total 3 (delta 1), reused 0 (delta 0)
To git@git.xxx.org:ops/puppet.git
   925d4ec..3ee0b45  fix_me -> fix_me


Review your PR:
--------
Title:
fix_me

Body:


--------
Submit pull request? (Y)
y
[success] Successfully created pull request #6: fix_me
Pull Request URL: https://git.xxx.org/ops/puppet/pull/6
$  git reflow status production
Here's the status of your review:
    branches:     fix_me -> production
    number:       6
    reviewed by:
    url:          https://git.xxx.org/ops/puppet/pull/6
[notice] No one has reviewed your pull request.
$  git reflow deliver production
[deliver halted] No pull request exists for ops:fix_me
Please submit your branch for review first with `git reflow review`
$
@codenamev
Copy link
Collaborator

Looking into this. I'll see if I can get a release out this week with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants