Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isReleasesOrTags !== isReleases || isTags #168

Closed
2 of 3 tasks
fregante opened this issue Apr 13, 2023 · 2 comments · Fixed by #179
Closed
2 of 3 tasks

isReleasesOrTags !== isReleases || isTags #168

fregante opened this issue Apr 13, 2023 · 2 comments · Fixed by #179
Labels
bug Something isn't working under discussion

Comments

@fregante
Copy link
Member

fregante commented Apr 13, 2023

I think isReleasesOrTags is wrong.

  • isReleases: /user/repo/releases
  • isTags: /user/repo/tags
  • isReleasesOrTags: ?

You'd think that it would match ONLY those two URLs, but it also matches isSingleTag

https://refined-github.github.io/github-url-detection/?url=%2Frefined-github%2Frefined-github%2Freleases%2Ftag%2F2

Possible resolutions (non-exclusive):

  • drop isSingleTag from isReleasesOrTags
  • rename to isReleaseList and isTagList and isReleaseOrTagList
  • add isSingleReleaseOrTag
@yakov116
Copy link
Member

I have to find it i think we had an issue at one point, maybe the it matched new releases page or something like that.

But I agree it should be renamed to have list at the end

@fregante
Copy link
Member Author

it matched new releases page or something like that.

Yeah I think it was the opposite though: after editing a release, the release would appear on a bare /releases/tag/ list page instead of the expected /releases/tag/v1.0.0

I dropped that a while ago because it wasn't worth the extra bugs and complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working under discussion
Development

Successfully merging a pull request may close this issue.

2 participants