Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabnav overlay on PR page #1857

Closed
rohmanhm opened this issue Mar 14, 2019 · 5 comments
Closed

Tabnav overlay on PR page #1857

rohmanhm opened this issue Mar 14, 2019 · 5 comments

Comments

@rohmanhm
Copy link
Contributor

When you have very long git diff history I think it'll be nice if we have overlay tabnav PR on top, so it's more easy to switch between Conversation, Commit, Checks, and Files rather than just scroll to top to switch between those.

image

@fregante
Copy link
Member

I think it would become too tall and complex to stack 3 lines (tabs, issue header, file header)

@rohmanhm
Copy link
Contributor Author

Yeah I agree with you @bfred-it .

Maybe we could do with different approach like we positioning it on the left or we will have settings for refined-github so the user can choose what refined features the would to enabled/disabled.

But option number 2 seems too complicated to be implemented.

I don't know maybe you have a better idea.

@nesl247
Copy link
Contributor

nesl247 commented Mar 14, 2019

Maybe a scroll to top button would work?

@fregante
Copy link
Member

fregante commented Mar 14, 2019

Maybe a scroll to top button would work?

#1798

@fregante
Copy link
Member

fregante commented Mar 22, 2019

Closing because we can't handle 3 fixed lines. Press Home or + to scroll to the top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants