Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview GitHub activity in notifications without marking them as read #273

Closed
jamiebuilds opened this issue Jul 26, 2016 · 17 comments · Fixed by #284
Closed

Preview GitHub activity in notifications without marking them as read #273

jamiebuilds opened this issue Jul 26, 2016 · 17 comments · Fixed by #284

Comments

@jamiebuilds
Copy link
Contributor

Using the GitHub Notifications API it should be possible to create a little popover like the one below to show unseen activity using the last_read_at date.

screen shot 2016-07-26 at 1 09 13 pm

One of the biggest problems I have with lots of GitHub notifications is viewing them without marking them as read. Emails help this but they tend to get buried and are not organized by user/repo. GitHub notifications could use some love

@DrewML
Copy link
Contributor

DrewML commented Jul 26, 2016

Oooh, that's a pretty good idea. I like it! This would require adding a settings panel, though (so users can enter their GitHub API key for private repo access). Sindre has tried to avoid adding a settings panel.

@sindresorhus thoughts? We could also add this for only public repos, but that might be a bit of a weird experience from a UX perspective when some items work on hover and others don't.

@jamiebuilds
Copy link
Contributor Author

Public repos would be enough for me to be happy, those are the repos that have an unmanageable amount of notifications

@paulmolluzzo
Copy link
Contributor

This is a really neat idea! If we go down the path of only showing this for public repos it might be worth indicating the ones that you can hover to preview. Maybe include the eye icon for the target to :hover on?

@sindresorhus
Copy link
Member

Love it! I have the same issue as @thejameskyle. We can do public repos first and see.

@DrewML
Copy link
Contributor

DrewML commented Jul 27, 2016

Started working on this tonight. I should have spotted this sooner, but the "Notifications API" requires an authentication token (which makes sense).

The notification link does include the ID of the comment that triggered the notification, so we can make a request to that page. However, I don't know if doing that is going to dismiss the notification. I'll wait for someone to reply to this thread so I have a new unread notification to test with 😎

@sindresorhus
Copy link
Member

Reply

@DrewML
Copy link
Contributor

DrewML commented Jul 27, 2016

Damn - hitting the URI at all dismisses the notification. I think the only way forward with this feature is providing users a way to add a GH API key.

@DrewML
Copy link
Contributor

DrewML commented Jul 28, 2016

What do you think @sindresorhus? If we add the ability to enter an API key, it might open up an avenue to some other cool features we wouldn't be able to pull off without the API.

@sindresorhus
Copy link
Member

Sure

@jamestalmage
Copy link

Ooh. If that's on the table, let's add a marker on the notifications page that differentiates notifications where you are @-mentioned. I would love to be able to prioritize what I read that way

@DrewML
Copy link
Contributor

DrewML commented Aug 1, 2016

@jamestalmage Want to open a separate issue for that one? I can do the API-key work for this PR first, get that committed, and then we'll be able to work on this issue + your idea in parallel.

@DrewML
Copy link
Contributor

DrewML commented Aug 6, 2016

Still have plans to finish out what I started on this. Just hitting some timing issues w/ moving + priorities on other projects.

@vadimdemedes
Copy link

Hey guys, I've implemented a different approach to this problem, the way I always wanted it to be - check out PR #284 and let me know what you think over there!

Idea by @thejameskyle is great and certainly looks nice, but sometimes I want to give a thread another glance to understand the context of another person's reply. Because of that, a popover wouldn't work for me. Instead, I decided to add "Mark as unread" buttons to the sidebar on every issue/pr page:

screen shot 2016-08-20 at 2 46 08 pm

@jamiebuilds
Copy link
Contributor Author

@sindresorhus did you intend to close this via #284?

@sindresorhus
Copy link
Member

Nope. This is complementary to #284.

@sindresorhus sindresorhus reopened this Sep 4, 2016
@hkdobrev
Copy link
Contributor

@DrewML Do you still have plans to publish your work regarding the API token?

@fregante
Copy link
Member

I see this as complementary to #181 into its own "Notifications Preview for GitHub" extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

8 participants