Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "title" attr to emojis #278

Closed
DrewML opened this issue Aug 8, 2016 · 5 comments
Closed

Add "title" attr to emojis #278

DrewML opened this issue Aug 8, 2016 · 5 comments
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@DrewML
Copy link
Contributor

DrewML commented Aug 8, 2016

Sometimes I have absolutely no idea what an emoji is that someone has used. The markup GitHub uses when rendering emojis is:

<g-emoji alias="cat" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f431.png">馃惐</g-emoji>

It would be nice to be able to hover on the icon to actually see what it's name is. This would just involve copying the alias value to title.

Any objections?

@sindresorhus
Copy link
Member

I find the g-emoji thing annoying. They make emoji render different than the native. Example: https://github.com/sindresorhus/skin-tone (See the first emoji in the description):
screen shot 2016-08-08 at 23 21 59

I actually wanted to remove it, but if you see a value in it, we should at least remove the g-emoji style that makes it different.

@jacobbearden
Copy link
Contributor

Might be platform based but for me, emojis do have a title attribute:

image

and the markup is:

<g-emoji alias="ok_hand" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44c.png"><img class="emoji" title=":ok_hand:" alt=":ok_hand:" height="20" width="20" src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44c.png"></g-emoji>

On an Ubuntu based operating system, using Chrome

@jgierer12 jgierer12 added enhancement small Issues that new contributors can pick up help wanted labels May 14, 2017
@lukaszklis
Copy link
Contributor

What is the expected result here in the end? Adding the title attribute for g-emoji and removing the styling?

@hkdobrev
Copy link
Contributor

@jacobbearden It seems on Ubuntu the fallback-src is transferred to an <img> element with a title. Probably the raw emoji there is not supported.

@hkdobrev
Copy link
Contributor

@lukaszklis I think we should at least have the title attribute before anything else as it's quite annoying. This is what the original issue is about.

@sindresorhus could you clarify what you mean? Perhaps revert the whole <g-emoji> and in practice force the fallback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

No branches or pull requests

6 participants