-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "title" attr to emojis #278
Comments
I find the I actually wanted to remove it, but if you see a value in it, we should at least remove the |
Might be platform based but for me, emojis do have a title attribute: and the markup is: <g-emoji alias="ok_hand" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44c.png"><img class="emoji" title=":ok_hand:" alt=":ok_hand:" height="20" width="20" src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44c.png"></g-emoji> On an Ubuntu based operating system, using Chrome |
What is the expected result here in the end? Adding the |
@jacobbearden It seems on Ubuntu the fallback-src is transferred to an |
@lukaszklis I think we should at least have the title attribute before anything else as it's quite annoying. This is what the original issue is about. @sindresorhus could you clarify what you mean? Perhaps revert the whole |
Sometimes I have absolutely no idea what an emoji is that someone has used. The markup GitHub uses when rendering emojis is:
It would be nice to be able to hover on the icon to actually see what it's name is. This would just involve copying the
alias
value totitle
.Any objections?
The text was updated successfully, but these errors were encountered: