Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enabling new font again? #293

Closed
karlhorky opened this issue Sep 4, 2016 · 7 comments
Closed

Consider enabling new font again? #293

karlhorky opened this issue Sep 4, 2016 · 7 comments

Comments

@karlhorky
Copy link
Contributor

This extension has lots of awesome features, but it disables GitHub's new larger and more legible fonts. Also, like @zeke mentioned in #261 (comment) having the major design features the same as other users can be useful when helping others out.

Are you open to considering reenabling the new fonts? They are quite nice after you adjust to them...

@zeke
Copy link
Contributor

zeke commented Sep 5, 2016

They are quite nice after you adjust to them...

Agreed. It took me 24 hours to adjust.

@karlhorky
Copy link
Contributor Author

Ping contributors @sindresorhus @paulmolluzzo @DrewML, any feedback for this one?

I guess @hkdobrev is against this change... can you post your reasoning shortly? Is it because the text is larger and you can fit less on your screen?

@hkdobrev
Copy link
Contributor

I just can't get used to the font. I've tried to give it a try twice and I don't read it as easily as the previous one. It looks to me like something with the anti-aliasing is off and I feel like this is a font which one would use for a terminal / source code. Even if it gets reverted I'd probably add a custom css override for me for the old fonts.

@zeke
Copy link
Contributor

zeke commented Sep 20, 2016

Even if it gets reverted I'd probably add a custom css override for me for the old fonts.

Judging by emoji reactions, it's what most people want.

@lipis
Copy link

lipis commented Nov 5, 2016

Yes please.. the new font (right side) is much better... :)

screen shot 2016-11-06 at 00 23 10

@sindresorhus
Copy link
Member

Ok, done. GitHub has tweaked the font usage a lot since its inception and I think it's good enough now to adopt. And it's honestly a bit more readable. I'm leaving the old tweaks commented out for people wanting to preserve the old font. In the future, we might consider making the custom.css file editable in the options as it contains some highly opinionated overrides.

@hkdobrev
Copy link
Contributor

hkdobrev commented Nov 6, 2016

@sindresorhus I was about to do a PR with the same as it seems I was the only one against it. I tested the new font this week as well and even used GitHub without the extension for a few days. I still have trouble with the new font on long texts, but I'll see if I'll get used to it or modify it for myself. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants