-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop notifications #296
Comments
I would love that personally. I would work on a fork with you if you'd like, for sure. |
I've looked into this a bit more now and it might not be possible to implement this in a reliable way after all. The reason for that is GitHub not having an official WebSocket API and polling the Notifications API isn't a great solution. Additionally it seems that there is currently way to access the API directly in this plugin due to the missing auth token required for authenticated API requests. An alternative would be opening https://github.com/notifications in some sort of invisible iframe maybe and watching it for updates, but unfortunately that page only updates on browser refresh and not via their internal WebSocket pubsub system. |
There is a dedicated extension for this functionality here. |
Oh cool, last time I tried that plugin I think it didn't have that functionality yet... |
I'm going to close this for now, since there is another (maintained) extension that (as I understand it) accomplishes this functionality. If there is a really good reason that can be made for pulling this into |
I wonder if it was possible to use the Notification API to show desktop notifications for incoming notifications from GitHub. Is that something that would potentially get merged or would that be wasted energy?
The text was updated successfully, but these errors were encountered: