Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop notifications #296

Closed
Turbo87 opened this issue Sep 9, 2016 · 5 comments
Closed

Desktop notifications #296

Turbo87 opened this issue Sep 9, 2016 · 5 comments

Comments

@Turbo87
Copy link
Contributor

Turbo87 commented Sep 9, 2016

I wonder if it was possible to use the Notification API to show desktop notifications for incoming notifications from GitHub. Is that something that would potentially get merged or would that be wasted energy?

@devoxel
Copy link

devoxel commented Sep 10, 2016

I would love that personally.

I would work on a fork with you if you'd like, for sure.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Sep 10, 2016

I've looked into this a bit more now and it might not be possible to implement this in a reliable way after all. The reason for that is GitHub not having an official WebSocket API and polling the Notifications API isn't a great solution. Additionally it seems that there is currently way to access the API directly in this plugin due to the missing auth token required for authenticated API requests.

An alternative would be opening https://github.com/notifications in some sort of invisible iframe maybe and watching it for updates, but unfortunately that page only updates on browser refresh and not via their internal WebSocket pubsub system.

@DrewML
Copy link
Contributor

DrewML commented Sep 11, 2016

There is a dedicated extension for this functionality here.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Sep 11, 2016

Oh cool, last time I tried that plugin I think it didn't have that functionality yet...

@DrewML
Copy link
Contributor

DrewML commented Sep 12, 2016

I'm going to close this for now, since there is another (maintained) extension that (as I understand it) accomplishes this functionality. If there is a really good reason that can be made for pulling this into refined-github, we can re-open this issue to discuss more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants