Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "toggle all with alt-click" to batch-mark-files-as-viewed #3043

Closed
2 tasks done
fregante opened this issue Apr 29, 2020 · 1 comment · Fixed by #4016
Closed
2 tasks done

Add "toggle all with alt-click" to batch-mark-files-as-viewed #3043

fregante opened this issue Apr 29, 2020 · 1 comment · Fixed by #4016
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Apr 29, 2020

Follows #3007

  • Add alt-click to toggle all ("all loaded files")
  • Add a "in progress" indicator next to the counter, because the marking might take a few seconds:
    counter
@fregante
Copy link
Member Author

fregante commented May 1, 2020

  • Add a "in progress" indicator

I saw GitHub using this, it might be less troublesome than adding elements to that bar. It can also be used for other features.

<div role="log" style="z-index: 101;" class="
  position-fixed bottom-0 left-0 ml-5 mb-5
  anim-fade-in fast Toast
  Toast--loading">
  <span class="Toast-icon">
      <svg class="Toast--spinner" viewBox="0 0 32 32" width="18" height="18">
        <path fill="#959da5" d="M16 0 A16 16 0 0 0 16 32 A16 16 0 0 0 16 0 M16 4 A12 12 0 0 1 16 28 A12 12 0 0 1 16 4"></path>
        <path fill="#ffffff" d="M16 0 A16 16 0 0 1 32 16 L28 16 A12 12 0 0 0 16 4z"></path>
      </svg>
  </span>
  <span class="Toast-content">Bulk actions currently being processed.</span>
</div>

<div role="log" style="z-index: 101;" class="
  position-fixed bottom-0 left-0 ml-5 mb-5
  anim-fade-in fast Toast
  Toast--success" >
  <span class="Toast-icon">
      <CheckIcon />
  </span>
  <span class="Toast-content">Bulk action processing complete.</span>
    <button class="Toast-dismissButton" type="button" aria-label="Close">
      <XIcon />
    </button>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

1 participant