New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compare diff URLs in prevent-pr-commit-link-loss
#3528
Labels
Comments
fregante
added
enhancement
under discussion
help wanted
and removed
under discussion
labels
Sep 4, 2020
can I work on this issue? |
@esakki-selvaraj go for it! |
@yakov116 Can i get some more links so that I can check my Reg Expression! |
Keep in mind that there's a pretty advanced regex (which avoids selecting the url twice) already set up: And tested: You should start from that regex: copy the regex, copy the tests (changing only the URLs) and make sure they pass. |
it's working |
fregante
changed the title
Support compare diff URLs to
Support compare diff URLs in Sep 20, 2020
prevent-pr-commit-link-loss
prevent-pr-commit-link-loss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Copy-paste this URL in a comment a click "Preview"
GitHub changes the URL to the following, breaking it
This is a similar GitHub bug to #2327, which was fixed by #3085 (prevent-pr-commit-link-loss), so it'd make sense to extend that feature
The text was updated successfully, but these errors were encountered: