Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to turn off all features that hide something from GitHub #3843

Closed
aminya opened this issue Dec 25, 2020 · 11 comments
Closed

An option to turn off all features that hide something from GitHub #3843

aminya opened this issue Dec 25, 2020 · 11 comments

Comments

@aminya
Copy link

aminya commented Dec 25, 2020

I like refined-GitHub and use it everywhere, but I don't like some of the features that hide something from GitHub, and this possibility that every extension update can hide something new. I prefer to use refined-GitHub for the features it "adds", not hiding UI elements.

Could you add a switch to the extension that allows us to batch disable these features? This also removes the need for checking the list every once in a while, to disable those new hider features.

Before downvoting this issue, keep in mind that I am just asking for an option.

The list is so long that it takes a lot of time to find all of them one by one and disable them. This has put a burden on me recommending this extension to others.

Some of these that I have found:

image
image
image
image

@aminya
Copy link
Author

aminya commented Dec 25, 2020

Before downvoting or closing this issue, keep in mind that I am just asking for an option. It is sometimes good to accept that there may be other preferences and maybe GitHub had a reason for adding those elements.

cc: @yakov116 @sindresorhus

@yakov116
Copy link
Member

So you want an option to disable options? Nope ain't gonna happen.

It is sometimes good to accept that there may be other preferences and maybe GitHub had a reason for adding those elements.

We already take into account other peoples preference by allowing users to easily disable features.

You want an option to disable this set of feature, the next person wants an option to only have enabled another set of features... there is no end.

Thanks for your understanding.

@cheap-glitch
Copy link
Member

This also removes the need for checking the list every once in a while, to disable those new hider features.

You can subscribe to the GitHub releases to be notified every time a new feature might have appeared. They come with a pretty detailed changelog, not to mention the "NEW" labels in the feature list that make it easy to spot new features.

The list is so long that it takes a lot of time to find all of them one by one and disable them. This has put a burden on me recommending this extension to others.

But isn't it a good thing to comb through the list at least once and check every feature? I mean, otherwise you're just blindly trusting the extension.

@aminya
Copy link
Author

aminya commented Dec 25, 2020

So you want an option to disable options? Nope ain't gonna happen.

No worries! I just thought you might be open to considering other people's preferences.

To fix this issue, I have set up a fork disabling these features by default. Once published in the Chrome store and Firefox, I would close this issue.

https://github.com/aminya/github-extras

You can subscribe to the GitHub releases to be notified every time a new feature might have appeared. They come with a pretty detailed changelog, not to mention the "NEW" labels in the feature list that make it easy to spot new features.

Thanks for the tip.

But isn't it a good thing to comb through the list at least once and check every feature? I mean, otherwise you're just blindly trusting the extension.

I am not someone who does not trust open-source projects. If I wanted to not trust this extension, I had to read all the source code of this extension, which I don't have time for. Checking the extensions page is not representative of the security/safety of this extension.

@busches busches closed this as completed Dec 25, 2020
@fregante
Copy link
Member

This is the problem with having 200 features, everyone has their own opinion on what they like and what they don’t. Grouping, disabling by default, etc have been requested in the past, but they don’t help the core problem: someone still won’t agree on the defaults or will expect different groupings.

It’s 200 features, there’s no winning, the only way forward is to fix any problems with the existing features (like #3832) and filtering new feature requests so that they effectively improve the experience for most developers (which we already do)

If you are nitpicky, you already have the option to disable the features you don’t like, but that of course requires you to go through the list. We also have an option to show which features are enabled on each page, so that should make it a little easier to find something that bothers you.

@fregante
Copy link
Member

fregante commented Dec 25, 2020

What I would love to see is a way to anonymously and voluntarily collect the reason why some features are being disabled. For example the options could show a message like

5 features have been disabled, would you mind anonymously explaining why? Fill in this form

And the form would be pre-filled with each disabled feature. The form would have to be external because I don’t want the extension to “collect” any data whatsoever.

@jerone
Copy link
Contributor

jerone commented Dec 26, 2020

I never expressed my opinion about this, but I have the same preference as the author of this issue.

Luckily, naming convention is very consistent in this extension, so once in a while I go to the settings and search for the word hide. This will give all the features that "hide" parts of the UI. Choose the features that you want to disable.

@aminya
Copy link
Author

aminya commented Dec 27, 2020

What I would love to see is a way to anonymously and voluntarily collect the reason why some features are being disabled. For example the options could show a message like

@fregante I am not shy to express my opinions publicly, and that is why I have made this issue. Anonymous messages are good, but I am not afraid of saying what I think.

My problem with the current default options is that you are removing/hiding things that GitHub has put effort to make based on an opinionated set of features. These are different from the new additive features that everyone loves.

I want to make Refined-GitHub more inclusive, and so that is why I want to pay Google 5$ just to host GitHub-Extras.

In my fork, I created a list of feature removers. They are disabled by default and are marked as feature-remover in the extension list. This makes GitHub extras less opinionated. Not having these on by default, also increases the performance of GitHub.

https://github.com/aminya/github-extras/blob/e8486a54f23e4858ab4949091eb3a713592cfceb/source/options-defaults.ts#L3-L30

image

I also made a list of other disabled features. Those that I don't think should be enabled by default:

  • "set-default-repositories-type-to-sources": discourages forking and collaboration in favor of hosting personal repositories. Not everyone has 100s of repositories hosted on their personal account like how @sindresorhus does
  • "quick-repo-deletion", very dangerous. Not everyone gets 10s of stars when they host something on GitHub. Also see quick-repo-deletion activating by default seems overly aggressive #3832
  • "edit-files-faster" still buggy in my browser

https://github.com/aminya/github-extras/blob/e8486a54f23e4858ab4949091eb3a713592cfceb/source/options-defaults.ts#L31-L35

@fregante
Copy link
Member

fregante commented Dec 27, 2020

  • quick-repo-deletion", very dangerous. Not everyone gets 10s of stars

You only need 1 star, you can star your own repos. #3832 will come

  • "edit-files-faster" still buggy in my browser

Buggy how? Can you report the issue? Eventually all features will break, so you'll end up with nothing enabled.

@fregante
Copy link
Member

Features like clean-sidebar and clean-conversation-headers are a plus because they help you focus on the important content rather than filler and duplicates.

clean-conversation-filters and cleanup-repo-filelist-actions are required because you can't keep adding buttons without making room for them. I guarantee that GitHub Extras will suffer the exact bugs that those 2 features exist to prevent.

@fregante
Copy link
Member

fregante commented Dec 27, 2020

  • set-default-repositories-type-to-sources": discourages forking and collaboration in favor of hosting personal repositories.

This makes sense, however:

  • GitHub already does that by blurring the lines between a meaningful fork and a fork created just to contribute
  • the vast majority of users have the latter type of fork cluttering up their repository list

This means that regardless of our extension, finding meaningful forks in the repository list is like looking for the infamous needle in a haystack. Nobody likes that, thus Refined GitHub hides the haystack. Sorry forks, blame it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants