Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💯 Minor codebase updates and fixes #4008

Closed
1 task
fregante opened this issue Feb 21, 2021 · 48 comments
Closed
1 task

💯 Minor codebase updates and fixes #4008

fregante opened this issue Feb 21, 2021 · 48 comments
Labels
help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Feb 21, 2021

I'll use this issue to add small tasks that could be done, treat it as a wishlist or a good way to start getting acquainted with the codebase.

  • Find fickle selectors and change them with select(something more specific).closest(the parent);

    GitHub has been removing some feature-specific classes like .js-file-list which means that we end up with monstrosities like main > :first-child .mt-1 .btn which mean nothing and could change at any time. Ideally instead we should find the best selector inside the target element (for example its icon, select('.octicon-branch[aria-label="Create branch"]')) and then reach the desired element with .closest('.btn'):

    - select('main > :first-child .mt-1 .btn')
    + select('.octicon-branch[aria-label="Create branch"]')!.closest('.btn')
  • Better yet: Replace select().closest() calls with :has #4456

@fregante fregante added help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up labels Feb 21, 2021
@doc-han

This comment has been minimized.

@fregante

This comment has been minimized.

@cheap-glitch

This comment has been minimized.

@fregante

This comment has been minimized.

@yakov116

This comment has been minimized.

@fregante

This comment has been minimized.

@yakov116

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante

This comment has been minimized.

@yakov116

This comment has been minimized.

@yakov116 yakov116 mentioned this issue Apr 7, 2021
@cheap-glitch

This comment has been minimized.

@yakov116

This comment has been minimized.

@fregante

This comment was marked as resolved.

@fregante

This comment has been minimized.

@sindresorhus

This comment was marked as resolved.

@cheap-glitch

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante
Copy link
Member Author

@fregante

This comment has been minimized.

@fregante

This comment has been minimized.

@fregante fregante changed the title Minor codebase updates and fixes 💯 Minor codebase updates and fixes Dec 10, 2021
@fregante
Copy link
Member Author

fregante commented Dec 10, 2021

Let's not add any more requests to this issue. A new one can be created. We'll close this one after (almost) everything is done.

🛁 #5222

@FloEdelmann

This comment has been minimized.

@fregante

This comment was marked as resolved.

@FloEdelmann

This comment was marked as resolved.

@fregante
Copy link
Member Author

Closing and locking. Thanks for all the fish!

@refined-github refined-github locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up
Development

No branches or pull requests

7 participants