Remove Milestones filter if there are no milestones

[hkdobrev]

When there are no milestones the filter in issues and PRs listing page in a repo still have a filter for milestones which is not useful at all. There's just one option which just shows all issues/PRs with no milestones which are basically every issue/PR.

I think this would reduce clutter for projects not using milestones and not change anything if you're using milestones.

[sindresorhus]

👍

[busches]

I took a stab at this, but the milestone list isn't loaded until you attempt to filter on it. Is there another way we can determine if they're using milestones outside of what's in the list and if not, do we want to call the list all the time just to remove it?

busches@920554d

[sindresorhus]

@busches Use MutationObserver.

[busches]

@sindresorhus that seems clunky though. I'd click on Milestones and then it'd load the list, it has no milestones, and we'd immediately remove it?

[sindresorhus]

Ok, I misunderstood how it worked.

[fregante]

This requires a fetch to the API to check if a project has any Milestones. Is it worth it?

[yakov116]

@bfred-it I think only if its not your not part of the repo because

Thought were talking about assigning a milestone