Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-pr-commit-title compatible with default merges #4614

Closed
louisefindlay23 opened this issue Jul 27, 2021 · 2 comments
Closed

sync-pr-commit-title compatible with default merges #4614

louisefindlay23 opened this issue Jul 27, 2021 · 2 comments

Comments

@louisefindlay23
Copy link

Description

The existing sync-pr-commit-title feature is very useful to automate replacing the merge commit default title Merge pull request #3041 from achiengrhoda/Getting-started-with-Packet-Tracer which is long and cluttered with the PR title which is far more succinct and to the point.

However, it only works for squash and commit merges and not default merges. Having the ability to use this great feature for those who use default merges would be very useful and desireable.

Screenshot

sync-pr-commit-title Screenshot

Example URL

section-engineering-education/engineering-education#2896

@fregante
Copy link
Member

fregante commented Jul 27, 2021

That's how it worked initially but after some complaints we limited it to squash commits:

There's also a similar request here with more discussion:

Given that the workflow and expectations of different people vary, either we leave the default commit title (current situation) or add a button to copy the PR title on merges.

@louisefindlay23
Copy link
Author

Thanks, Federico. I think it would be nice to have a button to do this.

Will close this issue in favour of #2768.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants