Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many features should not run on certain types of pages #5356

Closed
1 of 6 tasks
kidonng opened this issue Jan 31, 2022 · 3 comments
Closed
1 of 6 tasks

Many features should not run on certain types of pages #5356

kidonng opened this issue Jan 31, 2022 · 3 comments
Labels
help wanted meta Related to Refined GitHub itself

Comments

@kidonng
Copy link
Member

kidonng commented Jan 31, 2022

Description

Sometimes a category of features should not run on certain type of page, either because it is not functioning or it doesn't make sense.

Maybe this is brought up before, but let's create a new tracker for this type of issue. Due to the number of features we have, the issue isn't going to be solved in one PR or two, so feel free to include eligible features in existing or new PRs (and tag this issue).

Insufficient permission

  • Archived repo: Skip some features on archived repositories #5355
  • Actions that require you to be a collaborator (e.g. editing labels, locking conversations)
  • Actions that require you to be able to change repo settings
  • Locked conversations (comment-related features should not run)

Completely different

Screenshot

No response

Example URL

N/A

@fregante
Copy link
Member

fregante commented Feb 2, 2022

@kidonng
Copy link
Member Author

kidonng commented Feb 2, 2022

It is linked as gist.github.com above. This issue is about a broader topic.

@fregante
Copy link
Member

fregante commented Jun 1, 2023

Ehhh, I like the intent, but this kind of issue rarely lead to changes unless the interested party takes action.

In this case specifically, we already do address this wherever noticed or remembered (we have a few "exclude: isArchived") but the effort is better spent on actually broken features instead of spending time looking at every feature that might in some cases quietly do nothing.

#4779 would have been a good setup to avoid this issue, but for the same reason it was not implemented.

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted meta Related to Refined GitHub itself
Development

No branches or pull requests

2 participants