shorten-links processes way more links than required

[fregante]

Description

As the selector suggests, this feature is being applied to all the links on every page:

refined-github/source/features/shorten-links.tsx

Line 9 in 7dbc106

observe(`a[href]:not(.${linkifiedURLClass})`, {

We should look into the feature’s git history to see where this feature is expected to work exactly (e.g. only on markdown, likely) and make the selector more specific, perhaps even avoiding known-misses like these 2 links:

Natively shortened

#5888

Natively extended

• Load all comments from an issue #5888

How to replicate the issue

1. Visit https://github.com/refined-github/refined-github/issues
2. I don't think any links would ever need to be shortened on this page, but the feature is run on 258 links

Extension version

any

Browser(s) used

any

[fregante]

This is because we have a filter inside the callback:

refined-github/source/github-helpers/dom-formatters.ts

Lines 19 to 23 in 444a6aa

	export function shortenLink(link: HTMLAnchorElement): void {
	// Exclude the link if the closest element found is not `.comment-body`
	// This avoids shortening links in code and code suggestions, but still shortens them in review comments
	// https://github.com/refined-github/refined-github/pull/4759#discussion_r702460890
	if (link.closest(`${codeElementsSelector}, .comment-body`)?.classList.contains('comment-body')) {

I'm not sure if we can safely merge this given the history of this solution:

• Refactor linkify-code and shorten-links #4759

I don’t think :has() would be of help with that specific logic either. Related:

• :has() selector discussion #5797

[fregante]

I think we can still inline that selector before a[href], without altering the above logic. Like:

- observe(`a[href]:not(.${linkifiedURLClass})`)
+ observe(`:is(${codeElementsSelector}, .comment-body) a[href]:not(.${linkifiedURLClass})`)

This would limit the amount of times the callback is called.

Or maybe it's just this 🤔

- observe(`a[href]:not(.${linkifiedURLClass})`)
+ observe(`.comment-body a[href]:not(.${linkifiedURLClass})`)