Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native style for update-pr-from-base-branch #6127

Closed
fregante opened this issue Nov 2, 2022 · 3 comments · Fixed by #6537
Closed

Use native style for update-pr-from-base-branch #6127

fregante opened this issue Nov 2, 2022 · 3 comments · Fixed by #6537

Comments

@fregante
Copy link
Member

fregante commented Nov 2, 2022

A couple of years ago we used to show this button in the mergeability box but gave up because the box varied too much and it was difficult to track due to its dynamic nature (frequent updates).

But now we don't have issues with dynamic elements (via selector-observer) and I thought of a less error-prone way to integrate it:

  • inject a whole information bar just like GitHub does

I think we can do this with relative ease. The only issue is just the amount of JSX to maintain. We don't need 100% of the copy here.

Native

Screen Shot 5

Ours (current)

Screen Shot 6

@yakov116
Copy link
Member

yakov116 commented Nov 2, 2022

How do I trigger the native version?

@fregante
Copy link
Member Author

fregante commented Nov 3, 2022

@fregante
Copy link
Member Author

fregante commented Nov 5, 2022

I enabled it on this repo, together with CI requirements (native auto-merge, bye wait-for-checks)

Screen Shot 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants