Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "on menu opening/toggle" listeners with observe #6560

Closed
fregante opened this issue Apr 25, 2023 · 1 comment
Closed

Replace "on menu opening/toggle" listeners with observe #6560

fregante opened this issue Apr 25, 2023 · 1 comment
Labels
help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up

Comments

@fregante
Copy link
Member

fregante commented Apr 25, 2023

Most likely none of these actually need to use the toggle event and we can just observe the exact element we need

https://github.com/search?q=repo%3Arefined-github%2Frefined-github%20%27toggle%27&type=code

There are probably more listeners that use click to do the same thing, we might need to look at every delegate use

Part of:

@fregante
Copy link
Member Author

fregante commented Jun 1, 2023

Eh, the idea is there, but rewriting isn't necessary.

In some cases, we do want to listen to the toggle event, because observe only acts once.

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted meta Related to Refined GitHub itself small Issues that new contributors can pick up
Development

No branches or pull requests

1 participant