Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review @primer/octicons-react usage, update/replace dependency #6878

Closed
fregante opened this issue Sep 4, 2023 · 3 comments · Fixed by #7161
Closed

Review @primer/octicons-react usage, update/replace dependency #6878

fregante opened this issue Sep 4, 2023 · 3 comments · Fixed by #7161
Assignees
Labels
help wanted meta Related to Refined GitHub itself under discussion

Comments

@fregante
Copy link
Member

fregante commented Sep 4, 2023

Our @primer/octicons-react package cannot be updated:

There were a couple of attempts at fixing this:

Probably jsx-dom is the best transition we can do right now, but also it's probably not working with v19.

So I think the easiest way forward would be to:

  1. import the raw SVG
  2. have webpack turn it into JSX-compatible imports ("svgr")

This should be reasonably easy to implement and likely the most stable and lightweight solution (octicons-react has more code than we need, at this point)

@fregante
Copy link
Member Author

fregante commented Sep 4, 2023

Extracted from #6000 (comment)

@kidonng
Copy link
Member

kidonng commented Nov 30, 2023

This issue is made super visible by visit-tag (due to lacking of https://github.com//primer/octicons/pull/858)

image

@fregante
Copy link
Member Author

fregante commented Nov 30, 2023

Yeah let's restore SVGR soon so we'll skip all the React drama. I think the npm package still includes the SVG:

https://github.com/fregante/github-issue-link-status/blob/main/source/icons.js

(That file is handled by parcel so the syntax isn't the same)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted meta Related to Refined GitHub itself under discussion
2 participants