Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untruncate check descriptions in popup #6945

Closed
nfi-hashicorp opened this issue Sep 21, 2023 · 3 comments · Fixed by #7038
Closed

Untruncate check descriptions in popup #6945

nfi-hashicorp opened this issue Sep 21, 2023 · 3 comments · Fixed by #7038
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@nfi-hashicorp
Copy link

Description

When you click the little checks button next to a commit, it shows this popup. As you can see, long items are truncated. For matrix jobs, this happens often, which means you can't distinguish them if the differentiating factor is at the end:

image

I don't have great solution, but here's what it looks like if you hack the css-truncate class:

image

Personally I feel like that Detail text is superfluous and the text for the check could be the link.

Example URLs

https://github.com/hashicorp/consul for example, but anywhere those checks appear.

@fregante
Copy link
Member

fregante commented Sep 22, 2023

This is the kind of refinement I can get behind. However I guarantee that if we hide the Details button we'll immediately get a "bug report" that "Refined GitHub hid that link," even if we make the whole line visibly clickable.

@fregante
Copy link
Member

CSS-only PR welcome to wrap that text in clean-checks-list. I think it's not worth hiding "Details" at this moment

@fregante fregante added the small Issues that new contributors can pick up label Sep 22, 2023
@nfi-hashicorp
Copy link
Author

Thanks. I may or may not get to it, we'll see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted small Issues that new contributors can pick up
Development

Successfully merging a pull request may close this issue.

2 participants