Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table-input: editor button overflows in small enough viewport #7236

Closed
tranhl opened this issue Feb 1, 2024 · 6 comments · Fixed by #7259
Closed

table-input: editor button overflows in small enough viewport #7236

tranhl opened this issue Feb 1, 2024 · 6 comments · Fixed by #7259
Labels

Comments

@tranhl
Copy link

tranhl commented Feb 1, 2024

Description

At small enough viewports, the table-input button overflows when adding a comment to a PR during review. Seems like the "Add collapsible content" button also does the same thing.

Example of bug:

image

When hiding the file list, the button is correctly positioned:

image

How to replicate the issue + URL

URL: https://github.com/microsoft/vscode/pull/203467/files

  1. Open link above
  2. Click on "Add comment" button
image
  1. Observe table input button overflowing.

Extension version

24.1.10

Browser(s) used

Arc 1.27.3 (45706), Chromium Engine Version 121.0.6167.85

@tranhl tranhl added the bug label Feb 1, 2024
@ilike2burnthing
Copy link
Contributor

#7214

@fregante
Copy link
Member

fregante commented Feb 2, 2024

Thank you! Indeed this was fixed but not released yet. I'll try to release soon

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
@fregante
Copy link
Member

fregante commented Feb 2, 2024

All good in 24.2.2?

@ilike2burnthing
Copy link
Contributor

Unfortunately no. As long as table-input is enabled, the buttons overflow on a small textbox.

Edge v121.0.2277.98, Chrome 121.0.6167.140, Firefox 122.0
Windows 10 (confirmed with clean install in Sandbox)
Refined GitHub 24.2.2

@ForsakenHarmony
Copy link
Contributor

@fregante the attribute was applied to the wrong element
#7214 (comment)

@levrik
Copy link

levrik commented Feb 26, 2024

This feature seems to be broken completely right now for at least ~2 weeks or so.
The button is there, also correctly placed but does nothing when clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

5 participants