Storage Bus Lag

[Yamza]

Issue description:

Storage Buses seem to use an excessive amount of tick time
https://i.imgur.com/7h34zMc.png
https://i.imgur.com/ps0DtsO.png

Steps to reproduce:

1. Attach storage bus to chest
2. Check event log

Version (make sure you are on the latest version before reporting):

• Minecraft: 1.12.2
• Forge: 2760
• Refined Storage: 1.6.5
• Modpack: ATM3 - Remix 0.1.2

Does this issue occur on a server? [yes/no]
Yes

Not sure what kind of specific info you need but if you can walk me through getting it I would be happy to try.

Possibly unrelated but the controller is also quite excessive: https://i.imgur.com/iDc4qCe.png

[raoulvdberge]

https://refinedstorage.raoulvdberge.com/wiki/profiling

[Darkere]

Oh someone beat me to it.
Some additional info. I cannot reproduce this with just RS installed. Was looking into going through some potential candidates for mods that might be the cause today but maybe you can point me in the right direction.
Heres the sample file for it in ATM3:remix https://www.dropbox.com/s/0005hx76udrlkcj/sampler-snapshot.nps?dl=0
Newly genned world with just a creative controller and like 15 external storages on empty chests.

Also your link leads to an emtpy page.
https://refinedstorage.raoulvdberge.com/wiki/profiling is the page.

Oh and Yamza did you check if there was crafting going on with that controller? That looks similar to my crafting test.

[Yamza]

On a test world, for reference: https://i.imgur.com/3VhfUsp.png
Before placing storage bus: 8 micro-s/t: EVENT_BUS_LISTENER: {EVENT_BUS_LISTENER=Refined Storage
After: 1506 micro-s/t: EVENT_BUS_LISTENER: {EVENT_BUS_LISTENER=Refined Storage

Sampler: https://www.dropbox.com/s/bubr64hregfaxij/RS1.nps?dl=0
Spark: https://sparkprofiler.github.io/?WlhDcL4nBm

Edit: Put down 5 instances of this: https://i.imgur.com/0JiQJgS.png
8051 micro-s/t: EVENT_BUS_LISTENER: {EVENT_BUS_LISTENER=Refined Storage

[raoulvdberge]

Thank you, will take a look later.

[raoulvdberge]

@Yamza
I looked at your Spark/Sampler report:

RS shows 0.09% usage. Are you sure this is a real issue? Are you experiencing any lag, or are you just looking for ANY minimal tick rate usage?

[Yamza]

It is certainly a real issue on servers where multiple people will likely be using several of them. You did see the log SS in the initial report?

[raoulvdberge]

But were you able to SEE this issue in a realistic scenario? I'm not interested in assumptions here, I need REAL numbers of REAL usage.

[raoulvdberge]

To be even more clear: I'm not interested in "this WOULD be" or "this WOULD be LIKELY". I need a real report of real usage.

[Yamza]

The initial report is REAL usage on a REAL server where I REALly removed 6 RS external storage's and got REAL significant tps improvement. I do not currently have the ability to acquire a REAL report from the REAL server so what I have given you is all I am currently able to provide.

[raoulvdberge]

Okay, I'll be happy to handle a report of a REAL server with REAL usage then!

To clarify: I want to see if the TPS issues scale upwards, or if it stays static. This requires real server usage, not some hypothetical setup.

Your Sampler/Spark report didn't show anything significant either, so I'm curious to see if it escalates.

[Yamza]

Evidence of it scaling has already been provided.

[Darkere]

So I just had an idea...
So I ran Sampler once just looking at 20 storage busses.
https://www.dropbox.com/s/4rv0318675embwx/checkwithoutlaggoggles.nps?dl=0

And then I ran the same thing but during the 45s or so I ran 30seconds of Laggoggles profiling.
https://www.dropbox.com/s/jiw448kjiywbc0v/checkwithlaggoggles.nps?dl=0

And I found this:

Someone please tell me I didn't spend all that time looking for a false positive....
Gonna check if that is there with just RS and laggoggles as well.