Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-0 questions #21

Closed
keram opened this issue Jun 3, 2012 · 4 comments
Closed

2-0 questions #21

keram opened this issue Jun 3, 2012 · 4 comments

Comments

@keram
Copy link
Contributor

keram commented Jun 3, 2012

why public routes are ../connect/events.. and not directly ../events/.. or ../calendar?
for example

                   calendar_events_archive GET     /connect/events/archive(.:format)                         refinery/calendar/events#archive
                            calendar_events GET     /connect/events(.:format)                                 refinery/calendar/events#index
                             calendar_event GET     /connect/events/:id(.:format)                             refinery/calendar/events#show

In seed file is created "Venues" page instead page "Events" and I don't know if that is feature or just unfinished..
I don't want public page "Venues" at all.. (maybe this would be configurable or something like that?)
And last observation: admin page for creating/edit event seems to be unfinished too.

@joemsak do you want pull requests or some time for reviewing?

Btw i thinkin about writing extension to calendar ( for facebook events or doodle.com), but still not decided how

@joemsak
Copy link
Contributor

joemsak commented Jun 3, 2012

If you could please fix the routes that would be great they are from a client project by mistake. I'm out of town and no computer for a while

Thanks!

@joemsak
Copy link
Contributor

joemsak commented Jun 3, 2012

And yes I agree about no public venues view / controller. Left over generated code. Please feel free to clean up and pull request. Thanks!

@keram
Copy link
Contributor Author

keram commented Jun 10, 2012

sorry joe, (
I was thinking I get time for that this weekend but I was flooded with other work and development of other parts of the application

@joemsak
Copy link
Contributor

joemsak commented Jun 20, 2012

I will patch this...

I already removed public venue code

@joemsak joemsak closed this as completed Jun 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants