[REF-552] Reflex prints warning about Node binary not found

[masenf]

Running reflex init inside a fresh python:3.11 docker contain prints the following warning twice

Warning: The path to the Node binary could not be found. Please ensure that Node is properly installed and added to your system's 
PATH environment variable.

Which doesn't really make sense, because then it goes and bootstraps a version of node, which it then proceeds to use.

This warning should only be displayed if node is not installed, and Reflex is unable to bootstrap a version.

Present in 0.2.7a3

_{From SyncLinear.com | REF-552}

[Billa05]

@masenf I have made some changes, now how to verify changes locally?

[masenf]

@Billa05 please see https://github.com/reflex-dev/reflex/blob/main/CONTRIBUTING.md

[sgopalan98]

Hi @masenf

I looked at the source code for the problem that you mentioned. This is my understanding.

"reflex init" installs bun and node using processes.new_process function (called one time for each of their installation)

reflex/reflex/utils/processes.py

Lines 116 to 134 in 7019708

	def new_process(args, run: bool = False, show_logs: bool = False, **kwargs):
	"""Wrapper over subprocess.Popen to unify the launch of child processes.
	Args:
	args: A string, or a sequence of program arguments.
	run: Whether to run the process to completion.
	show_logs: Whether to show the logs of the process.
	**kwargs: Kwargs to override default wrap values to pass to subprocess.Popen as arguments.
	Returns:
	Execute a child program in a new process.
	"""
	node_bin_path = path_ops.get_node_bin_path()
	if not node_bin_path:
	console.warn(
	"The path to the Node binary could not be found. Please ensure that Node is properly "
	"installed and added to your system's PATH environment variable."
	)
	# Add the node bin path to the PATH environment variable.

In this function, node's bin path is fetched in order to be added to the PATH variable, and if node isn't installed, the warning that you mentioned is thrown.

Since python3:11 docker image doesn't have node installed by default, and we need to install node using fnm zip, it makes sense for the initial calls to install bun and node to throw these warnings (as these installation is done through processes.new_process).

So, I feel that this warning makes sense - as until we install node, the warning needs to be thrown... Your thoughts on this?