-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All chat shows as if you typed it #34
Comments
I'll look into this later. I have an idea of what might be causing it probably the placeholder is being replaced wrong |
@IasonKalaitzakis You can get a beta build here: https://github.com/RefracDevelopment/SimpleStaffChat/releases/tag/4.3.1-SNAPSHOT |
I've decided to just release this as is. |
Does not seem to be fixed in the 4.3.1 I downloaded from Spigot :/ |
@IasonKalaitzakis Alright i'll try some more stuff this really isn't an easy issue to fix since i have no way of testing this myself as i don't have any alts |
After some testing myself, it seems that your own place holders like %player% work fine, but as soon as I use other plugin's placeholders like %luckperms_prefix%%essentials_nickname% that I've been using, it uses my own instead of the senders. Hope that helps. |
hmm okay thanks yeah that should help |
@IasonKalaitzakis Here is a beta build for testing https://github.com/RefracDevelopment/SimpleStaffChat/releases/tag/Spigot-4.3.2 |
Same issue with 4.3.2, the plugin's own placeholders work alright but other plugins' placeholders use the current player's info instead of the senders info. |
@IasonKalaitzakis ah okay so it's PlaceholderAPI placeholders being replaced wrong hmm |
I'll release another beta soonish |
@IasonKalaitzakis Here is another beta build i've changed the way PlaceholderAPI placeholders are replaced: https://github.com/RefracDevelopment/SimpleStaffChat/releases/tag/Spigot-4.3.2-beta |
@IasonKalaitzakis ^ Just checking have you tried this yet? |
Ah sorry hadn't had a chance, will let you know as soon as I do :) |
Just tried it, all PAPI placeholders work fine as well. Ty for fixing :) |
Latest 4.3.0 version makes chat appear as if you typed everything, even if it is from other users.
This is three different people typing, but it shows up as if I typed everything^
Using the FreedomChat plugin that makes chat not reportable, not sure if that has any affect on it.
The text was updated successfully, but these errors were encountered: