Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All chat shows as if you typed it #34

Closed
IasonKalaitzakis opened this issue May 18, 2024 · 15 comments
Closed

All chat shows as if you typed it #34

IasonKalaitzakis opened this issue May 18, 2024 · 15 comments

Comments

@IasonKalaitzakis
Copy link

Latest 4.3.0 version makes chat appear as if you typed everything, even if it is from other users.

image
This is three different people typing, but it shows up as if I typed everything^

Using the FreedomChat plugin that makes chat not reportable, not sure if that has any affect on it.

@Refrac
Copy link
Member

Refrac commented May 18, 2024

I'll look into this later. I have an idea of what might be causing it probably the placeholder is being replaced wrong

@Refrac
Copy link
Member

Refrac commented May 18, 2024

@Refrac
Copy link
Member

Refrac commented May 21, 2024

I've decided to just release this as is.

@Refrac Refrac closed this as completed May 21, 2024
@IasonKalaitzakis
Copy link
Author

Does not seem to be fixed in the 4.3.1 I downloaded from Spigot :/

@Refrac
Copy link
Member

Refrac commented May 25, 2024

@IasonKalaitzakis Alright i'll try some more stuff this really isn't an easy issue to fix since i have no way of testing this myself as i don't have any alts

@Refrac Refrac reopened this May 25, 2024
@IasonKalaitzakis
Copy link
Author

After some testing myself, it seems that your own place holders like %player% work fine, but as soon as I use other plugin's placeholders like %luckperms_prefix%%essentials_nickname% that I've been using, it uses my own instead of the senders. Hope that helps.

@Refrac
Copy link
Member

Refrac commented May 25, 2024

hmm okay thanks yeah that should help

Refrac added a commit that referenced this issue May 25, 2024
@Refrac
Copy link
Member

Refrac commented May 25, 2024

@IasonKalaitzakis
Copy link
Author

Same issue with 4.3.2, the plugin's own placeholders work alright but other plugins' placeholders use the current player's info instead of the senders info.

@Refrac
Copy link
Member

Refrac commented May 26, 2024

@IasonKalaitzakis ah okay so it's PlaceholderAPI placeholders being replaced wrong hmm

@Refrac
Copy link
Member

Refrac commented May 26, 2024

I'll release another beta soonish

Refrac added a commit that referenced this issue May 26, 2024
@Refrac
Copy link
Member

Refrac commented May 26, 2024

@IasonKalaitzakis Here is another beta build i've changed the way PlaceholderAPI placeholders are replaced: https://github.com/RefracDevelopment/SimpleStaffChat/releases/tag/Spigot-4.3.2-beta

@Refrac
Copy link
Member

Refrac commented Jun 1, 2024

@IasonKalaitzakis ^ Just checking have you tried this yet?

@IasonKalaitzakis
Copy link
Author

@IasonKalaitzakis ^ Just checking have you tried this yet?

Ah sorry hadn't had a chance, will let you know as soon as I do :)

@IasonKalaitzakis
Copy link
Author

@IasonKalaitzakis ^ Just checking have you tried this yet?

Just tried it, all PAPI placeholders work fine as well. Ty for fixing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants