Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented #22: Make a proper 404 page. #68

Merged
merged 3 commits into from May 18, 2013
Merged

Implemented #22: Make a proper 404 page. #68

merged 3 commits into from May 18, 2013

Conversation

kevwilde
Copy link

No description provided.

@kevwilde kevwilde mentioned this pull request May 18, 2013
@meshy
Copy link
Contributor

meshy commented May 18, 2013

Closes #22

if settings.DEBUG:
urlpatterns += patterns('',
url(r'^404/', TemplateView.as_view(template_name='404.html')),
url(r'^500/', TemplateView.as_view(template_name='500.html')),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these have a dollar on the end, please? ie r'^500/$'

@meshy
Copy link
Contributor

meshy commented May 18, 2013

Thankyou so much!

@meshy
Copy link
Contributor

meshy commented May 18, 2013

As discussed, for very quickly checking mobile views without a mobile: http://responsive.victorcoulon.fr/

@meshy
Copy link
Contributor

meshy commented May 18, 2013

Good work! Thanks again!

meshy added a commit that referenced this pull request May 18, 2013
Implemented #22: Make a proper 404 page.
@meshy meshy merged commit ad36be7 into classy-python:master May 18, 2013
@kevwilde kevwilde deleted the 22-page-not-found branch May 18, 2013 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants