Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github: repost comment instead of updating existing comment #364

Closed
janpaul123 opened this issue Feb 3, 2021 · 3 comments 路 Fixed by #365
Closed

Github: repost comment instead of updating existing comment #364

janpaul123 opened this issue Feb 3, 2021 · 3 comments 路 Fixed by #365

Comments

@janpaul123
Copy link
Contributor

janpaul123 commented Feb 3, 2021

Is your feature request related to a problem? Please describe.

For the Github comment, it can be unclear that it has been updated. On our team we like to just add a 馃憤馃徎 emoji on the Github comment as a PR owner, to acknowledge that you've looked at the changes. But then if the comment gets updated, the 馃憤馃徎 remains, even if you haven't looked at the new changes.

Describe the solution you'd like

It would be nice to have an option to delete the comment and post a new comment. Or even just posting a new comment would suffice (without deleting the old one). For reference, Codecov does something similar, where you can select between 3 different ways of posting/updating a comment: https://docs.codecov.io/docs/pull-request-comments#behavior

Describe alternatives you've considered

Additional context

Screen Shot 2021-02-02 at 5 03 39 PM

Thanks again for an amazing set of tools!!!

@Quramy
Copy link
Member

Quramy commented Feb 3, 2021

For reference, Codecov does something similar,

It seems nice.

@Quramy
Copy link
Member

Quramy commented Feb 3, 2021

@janpaul123 I've added new option, prCommentBehavior .

You can switch to "Delete and Post" via:

/* regconfig.json */
{
  "core": {
    "workingDir": ".reg",
    "actualDir": "screenshot",
    "threshold": 0
  },
  "plugins": {
    "reg-notify-github-plugin": {
      "clientId": "xxxxxxx=",
      "prCommentBehavior": "new"
    },
  }
}

@janpaul123
Copy link
Contributor Author

Wow, thanks for the super fast implementation! 馃殌 It works perfectly. 馃挴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants