Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 publish in es5? #131

Closed
ysgk opened this issue Oct 18, 2019 · 4 comments · Fixed by #133
Closed

v2 publish in es5? #131

ysgk opened this issue Oct 18, 2019 · 4 comments · Fixed by #133

Comments

@ysgk
Copy link

ysgk commented Oct 18, 2019

Hi, thank you for this library. We are currently looking into storycap for our product.

Storycap v2 is currently published in esnext, but our product supports IE11. We need compile storycap, a 3rd party library in node_modules, using babel to make storybook run on IE. Updating babel config just for capturing stories seems to me a bit of an extra work. I would appreciate if you could publish storycap in es5. Any reason for publishing storycap in esnext although storybook itself is es5?

@Quramy
Copy link
Member

Quramy commented Oct 18, 2019

Oh, thanks. I’ll consider it!

@Quramy
Copy link
Member

Quramy commented Oct 21, 2019

Hi @ysgk . I've modified the transpiling target to ES5 and published it as v2.1.0. Please check it out 😄

@ysgk
Copy link
Author

ysgk commented Oct 24, 2019

@Quramy
Now babel is no longer needed 👍 IE is still throwing an error, because new URL is used here, though. I added url-polyfill and it's working fine now. Anyway, thank you for your quick response!

@Quramy
Copy link
Member

Quramy commented Oct 24, 2019

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants