Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cosmos sdk v0.47 updates #72

Open
ryanchristo opened this issue Jun 1, 2023 · 3 comments
Open

Add support for cosmos sdk v0.47 updates #72

ryanchristo opened this issue Jun 1, 2023 · 3 comments
Labels
dev Engineering task enhancement New feature or request help wanted Extra attention is needed

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Jun 1, 2023

Two new required fields have been added to MsgSubmitProposal in cosmos sdk v0.47 - title and summary (link). Given the intention to support multiple chains, ideally we would support both v0.46 and v0.47.

This would most likely require updating @regen-network/api to the latest proto files, which are non-breaking API changes, and maybe adding additional information to chain info that specifies which sdk version is being used and handling accordingly.

This feature was proposed in conversation with @gjermundgaraba.

@ryanchristo ryanchristo added the enhancement New feature or request label Jun 1, 2023
@ryanchristo ryanchristo changed the title Add support for cosmos sdk 47 updates Add support for cosmos sdk v0.47 updates Jun 1, 2023
@gjermundgaraba
Copy link

We are starting to work on the groups UI from our end, but figuring out this one, in particular, would go a long way to make sure we make changes that are "upstreamable".

Is the proposed solution of updating @regen-network/api something that can be done in a reasonable amount of time, or do you have other ideas in mind on how to solve this?

@ryanchristo
Copy link
Member Author

Updating the api package should be pretty straightforward. We'll need to test though and make sure it's backwards compatible, i.e. a chain running v0.46 can use the v0.47 api without any issues.

@ryanchristo
Copy link
Member Author

I've created an issue in the regen-js repository to track: regen-network/regen-js#76

@ryanchristo ryanchristo added dev Engineering task help wanted Extra attention is needed labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Engineering task enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants