Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved architecture for submodule wiring #1196

Closed
4 tasks
Tracked by #972
ryanchristo opened this issue Jun 17, 2022 · 0 comments
Closed
4 tasks
Tracked by #972

Improved architecture for submodule wiring #1196

ryanchristo opened this issue Jun 17, 2022 · 0 comments
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Jun 17, 2022

Summary

When implementing basket and marketplace functionality, we went with a submodule architecture. There are a lot of open questions remaining on how this architecture should look. Opening this issue to discuss improvements.

We currently have directories for each submodule within the root-level ecocredit module directory but each subdirectory only includes the generate types, the stateless message implementation, and stateless utility functions. The server/keeper and client implementation for each submodule is nested within submodule subdirectories within the root-level client and server directories but could be nested within the directories for each submodule within the root-level ecocredit module directory.

Should client and server/keeper directories for each submodule be nested within the root-level submodule directory? Do we plan on supporting multiple proto package versions for each submodule and, if so, how would this look? How will this submodule architecture work with cosmos-sdk v1? What improvements can we make to the submodule architecture approach?

Problem Definition

There is a lack of clarity on what submodule architecture should look like.

Proposal

[ work in progress ]


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

No branches or pull requests

2 participants