Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ecocredit event values when no value is provided #1333

Closed
4 tasks
Tracked by #972
ryanchristo opened this issue Aug 3, 2022 · 0 comments · Fixed by #1411
Closed
4 tasks
Tracked by #972

Fix ecocredit event values when no value is provided #1333

ryanchristo opened this issue Aug 3, 2022 · 0 comments · Fixed by #1411
Assignees
@technicallyty
Labels
good first issue Good for newcomers Scope: x/ecocredit Issues that update the x/ecocredit module Type: Fix

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Aug 3, 2022 •
edited
Loading

Summary

EventMint and EventTransfer use the zero-value for tradable_amount and retired_amount if not not set. We should be returning 0 rather than an empty string. We should also double check other events that might be using the zero-value.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@technicallyty technicallyty

Labels
good first issue Good for newcomers Scope: x/ecocredit Issues that update the x/ecocredit module Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(x/ecocredit): replace blank event values with actual values regen-network/regen-ledger
3 participants
@aaronc @ryanchristo @technicallyty