Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular updates to credit class fee and basket fee params #1359

Closed
4 tasks
Tracked by #972
ryanchristo opened this issue Aug 17, 2022 · 2 comments · Fixed by #1466
Closed
4 tasks
Tracked by #972

Granular updates to credit class fee and basket fee params #1359

ryanchristo opened this issue Aug 17, 2022 · 2 comments · Fixed by #1466
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Aug 17, 2022

Summary

Opening this issue to further discuss and track whether we want to provide support for adding, updating, and removing a single fee from the list of fees for parameters such as credit class fee and basket fee.

While migrating from legacy params to ORM params, the initial implementation (added in #1349 and #1354) adopts the same approach as legacy params, which requires updating the complete list of params.

If we want to make any changes, such changes should be included before the next release (i.e. v5.0).

Problem Definition

Updating fee params prior to message-based governance proposals required updating the whole list of fees in each proposal. We now have the option of adding, updating, and removing a single fee from the list.

Adding, updating, and removing individual fees from the list of fees would require three messages rather than one. The tradeoff would be more granular updates to fees and a better user experience with regards to not including existing fees when adding a fee but this would require more messages, one for each action (add, update, and remove), which might be excessive.

Proposal

(1) Keep the current implementation with one message that updates the entire list
(2) Add more granular messages for adding, updating, and removing a single fee from the list
(3) Switch to single fee with only one update method (as previously proposed in #1165)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@clevinson
Copy link
Member

Switching to a single fee makes sense to me. This would mean credit class fee, and basket fee are always in REGEN, right? I don't think we'd ever want globally to have a non-regen fee for basket or credit class creation.

@ryanchristo
Copy link
Member Author

ryanchristo commented Sep 1, 2022

Switching to a single fee makes sense to me. This would mean credit class fee, and basket fee are always in REGEN, right? I don't think we'd ever want globally to have a non-regen fee for basket or credit class creation.

We would probably still use Coin just not repeated so a governance proposal could technically update the fee to another token denom but the idea is the fee would always be regen and we would burn the fee (as we currently are). A single fee would reduce complexity for users and simplify governance proposals and using and burning regen would help serve healthy tokenomics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants