Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regen Ledger lint errors and add golint CI task #44

Closed
2 tasks
aaronc opened this issue Apr 12, 2019 · 3 comments
Closed
2 tasks

Fix Regen Ledger lint errors and add golint CI task #44

aaronc opened this issue Apr 12, 2019 · 3 comments
Assignees
Milestone

Comments

@aaronc
Copy link
Member

aaronc commented Apr 12, 2019

We want to be able to run golint ./... in CI. This mostly checks that all modules have appropriate doc strings. So this issue is mostly about adding missing source code documentation.

Definition of Done:

  • you can run golint ./... from the project root and there are no errors
  • there is a new CI stage that runs golint ./.... We should probably do this with https://github.com/golangci/golangci-lint instead of golint directly
@clevinson
Copy link
Member

@aaronc should this get closed ?

@aaronc
Copy link
Member Author

aaronc commented Feb 20, 2020

I think it's still relevant.

@aleem1314
Copy link
Contributor

This issue addressed in this golangci-lint PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants