Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regen module manager and use SDK App Module #933

Closed
4 tasks
Tracked by #972
robert-zaremba opened this issue Mar 24, 2022 · 5 comments · Fixed by #1357
Closed
4 tasks
Tracked by #972

Remove regen module manager and use SDK App Module #933

robert-zaremba opened this issue Mar 24, 2022 · 5 comments · Fixed by #1357
Assignees
Labels
Scope: types Issues that update the types module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@robert-zaremba
Copy link
Collaborator

Summary

Our custom App Module type and Configurator doesn't have any benefits compared to the SDK 0.46 App Module.
Let's remove it and migrate fully to SDK Module manager.

Problem Definition

Regen custom Configurator and App module was an experiment. It doesn't have enough benefits and it introduces additions maintenance costs and complexity


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added Scope: types Issues that update the types module Type: Refactor A code change that neither fixes a bug nor adds a feature Breaking Change: API Pull requests that introduce an API breaking change labels Mar 24, 2022
@ryanchristo
Copy link
Member

Is this necessary for the v4.0 upgrade? Should we maybe discuss this before putting it into the ready column?

@ryanchristo ryanchristo removed the Breaking Change: API Pull requests that introduce an API breaking change label Mar 26, 2022
@ryanchristo ryanchristo removed this from the v4.0 - Llangorse Upgrade milestone Mar 26, 2022
@aaronc
Copy link
Member

aaronc commented Mar 30, 2022

Agreed, but not sure we should worry about this for 4.0. With the new app wiring we'll want to migrate anyway when that's ready

@ryanchristo ryanchristo mentioned this issue Apr 2, 2022
34 tasks
@ryanchristo ryanchristo added this to the v5.0 - Titicaca Upgrade milestone Apr 2, 2022
@robert-zaremba
Copy link
Collaborator Author

I would put it as nice to have.
BTW, @ryanchristo why did you remove Api Breaking label? This task is about removing the whole public package, so it's API breaking.

@ryanchristo
Copy link
Member

ryanchristo commented Apr 4, 2022

I would put it as nice to have.

I already moved it to the new v5.0 epic and milestone. We can assess whether nice to have in that context at a later point in time since we are no longer planning to upgrade to Cosmos SDK v0.46 for the v4.0 release.

why did you remove Api Breaking label?

This label was originally created for pull requests. I created it back when we were transitioning to semantic commits. We could use it for issues too but if we start actively using it for all issues it might add more clutter than necessary to the board. We should probably reasses our labels and make sure we are consistently using them.

Let's maybe further discuss on our extended standup on Thursday.

@robert-zaremba
Copy link
Collaborator Author

moved discussion to Discord. I'm in a strong favor to keep labels. Github is our primary tool

@ryanchristo ryanchristo added Scope: app Scope: types Issues that update the types module and removed Scope: types Issues that update the types module Scope: app labels Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: types Issues that update the types module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants