-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove regen module manager and use SDK App Module #933
Comments
Is this necessary for the v4.0 upgrade? Should we maybe discuss this before putting it into the ready column? |
Agreed, but not sure we should worry about this for 4.0. With the new app wiring we'll want to migrate anyway when that's ready |
I would put it as nice to have. |
I already moved it to the new v5.0 epic and milestone. We can assess whether nice to have in that context at a later point in time since we are no longer planning to upgrade to Cosmos SDK v0.46 for the v4.0 release.
This label was originally created for pull requests. I created it back when we were transitioning to semantic commits. We could use it for issues too but if we start actively using it for all issues it might add more clutter than necessary to the board. We should probably reasses our labels and make sure we are consistently using them. Let's maybe further discuss on our extended standup on Thursday. |
moved discussion to Discord. I'm in a strong favor to keep labels. Github is our primary tool |
Summary
Our custom App Module type and Configurator doesn't have any benefits compared to the SDK 0.46 App Module.
Let's remove it and migrate fully to SDK Module manager.
Problem Definition
Regen custom Configurator and App module was an experiment. It doesn't have enough benefits and it introduces additions maintenance costs and complexity
For Admin Use
The text was updated successfully, but these errors were encountered: