Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.5 will deprecate MySQL functions currently in use; Pear_Error also to be deprecated #26

Closed
registrobr opened this issue Feb 15, 2013 · 9 comments
Milestone

Comments

@registrobr
Copy link
Collaborator

http://php.net/manual/en/migration55.deprecated.php

@ghost ghost assigned fkyanai Feb 19, 2013
@registrobr
Copy link
Collaborator Author

Pear: Error also seems to be deprecated or about to. From whmcs-coza-epp mailing list:

"110%, thanks Michael.

If we can track it down to that single PEAR_Error() I think that warrants me rewriting the module to use exceptions instead, seems that the PEAR Error() handling is marked as deprecated in alot of places v0v"

@registrobr registrobr modified the milestones: 1.01 version, 2.0 version Aug 22, 2014
@registrobr
Copy link
Collaborator Author

Currently not a problem since WHMCS doesn't support PHP 5.5 due to Ioncube restrictions. The new Ioncube loader supports PHP 5.5 but WHMCS, including up to 5.3.8, is encoded using previous Ioncube version that do not support the new loader. It is also said that WHMCS itself uses the same 5.5 deprecated versions, so it might be long before this issue becomes a problem.

Status might be changed from wontfix in the future; issue will remain open with no milestone.

@registrobr
Copy link
Collaborator Author

PHP 5.4 already complains about some of the issues:
Strict Standards: Non-static method PEAR::isError() should not be called statically in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Protocol.php on line 73

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in/home/super/public_html/home/modules/registrars/registrobr/RegistroEPP/RegistroEPP.class.php on line 172

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Client.php on line 112

Strict Standards: Non-static method PEAR::isError() should not be called statically in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Protocol.php on line 73

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Client.php on line 112

Strict Standards: Non-static method PEAR::isError() should not be called statically in /home/super/public_html/home/modules/registrars/registrobr/Net/EPP/Protocol.php on line 73

@registrobr
Copy link
Collaborator Author

Perhaps the changes already made at https://gitlab.centralnic.com/centralnic/php-epp/tree/master/Net/EPP solve the mentioned issues

@registrobr
Copy link
Collaborator Author

WHMCS v6 will support PHP 5.5+, so WHMCS v6 interoperability (besides possible registrar module issues yet to be known) might also require moving out of deprecated functions.

@rubenskuhl
Copy link
Contributor

WHMCS Version 6.0 supports PHP 5.3.7 or later, including PHP 5.4, 5.5 and 5.6.

@rubenskuhl
Copy link
Contributor

WHMCS Version 6.0 requires PHP Database Extension PDO

@rubenskuhl rubenskuhl added this to the v7.0 milestone Mar 28, 2019
@rubenskuhl rubenskuhl modified the milestones: v7.0, 8.0 version Apr 27, 2023
@rubenskuhl rubenskuhl reopened this May 14, 2023
@rubenskuhl
Copy link
Contributor

mysql_* functions that were removed still present in the code

@rubenskuhl
Copy link
Contributor

Commit df07b5d replaced all database functions with Capsule calls. New table layout defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants